Discovered in #2212437: Select::execute() needs @return docs, Select::havingCompile() simply calls ConditionInterface::compile(), and returns the result, but compile() is explicitly documented as not returning a value:

   * This method does not return anything, but simply prepares data to be
   * retrieved via __toString() and arguments().
CommentFileSizeAuthor
#1 2213297-select-havingcompile-1.patch571 byteslongwave
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented
Status: Active » Needs review
FileSize
2213297-select-havingcompile-1.patch571 bytes
Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Looks like that function is also missing PHPDoc. Is that covered in the referenced issue, or should we spin up a novice issue for that?

longwave’s picture

longwave
he/him
Primary language English
Location UK
CreditAttribution: longwave commented

#2212437: Select::execute() needs @return docs will cover documentation for all of the Select class.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented

s/will cover/covered/ -- that other issue's patch (also by longwave) has been committed. This was a spin-off issue. Go longwave!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.