Select::execute() needs @return docs

Thanks for getting carried away! Looks great!

I just noticed a couple of things, and then we can get this in:

a) core/lib/Drupal/Core/Database/Query/Select.php

+   * @return
+   *   An associative array of placeholders and values.
+   */
   public function havingArguments() {

This could say @return array ?

b) same class

+   * @return \Drupal\Core\Database\Query\SelectInterface
+   *   The called object.
+   */
   public function having($snippet, $args = array()) {

This should say @return $this with no docs on the next line. Same on havingIsNull(), havingIsNotNull(), havingExists(), havingNotExists(). That's kind of a new standard:
https://drupal.org/node/1354#types

c) same class

+  /**
+   * Compiles the HAVING clause for later retrieval.
+   *
+   * @param $connection
+   *   The database connection for which to compile the clause.
+   */
   public function havingCompile(Connection $connection) {
     return $this->having->compile($connection, $this);
   }

No @return here?

d) And regarding #2, it looks like both Select and SelectExtender implement that interface, and SelectExtender does not currently have all those methods, so not all of them can be moved to the interface. The ones that are already on SelectExtender are probably OK to move.

And one other thing, if you change code and not just docs, we'll need to get extra reviewers and move this to the database component.

Agreed. Looks good!

Patch no longer applies :(

Thanks for the reroll (and thanks again for the earlier patch)! Looks like a clean reroll, committed to 8.x.

longwave: it was your fix to that other issue about the having method that broke your patch here. ;)

doh! testbot that is because I already committed the patch!