The "Enable Panels IPE styles" and "Enable Panopoly Magic's modal styles" options are confusing, it would be better IMHO if the logic was changed around so that they said "Use Enber Support's styles for Panels IPE" and "Use Enber Support's styles for Panopoly Magic modals", and were checked by default.

Comments

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Category: Bug report » Feature request

I deliberated over this but its confusing both ways to me. I don't consider it a UX bug.

This module intends to have quite a few settings for various modules that it overrides. I consider it poor design to fill the variable store for every single module overridden, which is what seems necessary to take the approach requested.

Instead, I'd like to make available variables that, when enstated, actually revoke Ember's rights.

So when you check a check box you're effectively saying, "I'd like to turn the Panels IPE defaults on."

Perhaps there is better wording we can use in the admin settings that would make this clear?

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented

Though I suppose once the form has been saved once, you're setting a bunch of variables anyway. I was trying to avoid setting a bunch of stuff to TRUE on hook_install(). I definitely see where you are coming from on this.

damienmckenna’s picture

damienmckenna
Location TN, USA
commented

If the variables default are changed to TRUE then you don't have any variables until the settings form is saved.

How about renaming them to "Disable Ember Support's customized [thing]" or "Use the original [thing]"? Just something to make it clear that toggling the default value disables the Ember Support customization, and right now the checkbox labels are not very clear.

saltednut’s picture

saltednut
she/her
Primary language English
Location Chicago
commented
Status: Active » Fixed

I refactored the settings to make the checkboxes TRUE by default. I also broke apart the coupling of the Panopoly Magic override and Panels Modal override so that one could more easily use the module regardless of the presence of Panopoly. That said, it also leaves one open to having both the Panopoly and Ember CSS enabled at the same time. But that is not the default behavior. So the Panopoly Magic specific checkbox added is really just for testing purposes.

http://drupalcode.org/project/ember_support.git/commit/8c37786

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.