Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Just providing a composer.json file for plugins.
Eclipse
Comment | File | Size | Author |
---|---|---|---|
#12 | 2211633-12.patch | 811 bytes | EclipseGc |
Comments
Comment #1
EclipseGc CreditAttribution: EclipseGc commentedComment #2
dawehnerNow that drupal core requires php 5.4.2 I think it makes sense to do the same here to not block further improvements.
Comment #3
EclipseGc CreditAttribution: EclipseGc commentedWe've had this conversation for Utility as well, I'll say here what I said there, a 5.3.x dependency does not in any way retard forward momentum on Plugins. Drupal itself has a 5.4 dependency but its components should specify a dependency that is truly reflective of what they actually require. Plugin currently has no need for 5.4, and until it does, I don't see the point of updating the requirement in a pre-emptive nature. For more on this, you can read my comments here: #2210257: Bump \Drupal\Component\Utility's PHP requirement to 5.4.2
Eclipse
Comment #4
sun"classes and interfaces" ...refers to internal PHP aspects? Seems superfluous to me.
Does it "create" a pluggable subsystem?
I also think you're heavily under-rating the real power of this component. Some more marketing wouldn't hurt!
"plugin" would be a nice keyword? ;)
Are you sure that the current code in HEAD doesn't require PHP 5.4?
Comment #5
XanoHEAD does, but we've had a long discussion a while back and the conclusion was that \Drupal\Component will be separated from the rest of core more, and can have its own requirements.
Comment #6
dawehnerOne aspect we have to keep in mind is that we have to be able to "bundle" the components with its tests. At the moment they are in totaly different directories.
Comment #7
dawehnerI think at some point we for example will easily use "[]" for arrays, so we should not limit ourself to 5.3, for the sake of it.
Comment #8
EclipseGc CreditAttribution: EclipseGc commentedincorporated all feedback. I'd really like to see this get in.
Eclipse
Comment #9
dawehnerRelated issue, certainly #2337283: Add a composer.json file to every component
Did you considered to add authors (original developers etc.) into the composer.json file, see https://getcomposer.org/doc/04-schema.md#authors
Yeah, just to be clear, we even require 5.4. as we provide traits.
Comment #10
EclipseGc CreditAttribution: EclipseGc commentedI did not consider putting the authors on it. I did think about it, but it seems like it could have been a bit of a discussion and I wanted to streamline getting this in. As one of the Authors, I'm not horribly hung up on my name being on it or not. *shrugs* What I really want is to start offering it as a package that the rest of PHP can use, and this is the next step in making that happen.
Comment #11
dawehnerOkay cool, let's start now.
Comment #12
EclipseGc CreditAttribution: EclipseGc commentedActually we need a "suggests" in here. My bad. Shouldn't affect status. The suggests if for context aware plugins.
Eclipse
Comment #13
alexpottCommitted 0096eb0 and pushed to 8.0.x. Thanks!
Comment #15
EclipseGc CreditAttribution: EclipseGc commentedTHANK YOU!!!!
Comment #17
XanoThe composer.json file contains syntax errors. Fix and tests at #2472269: Fix syntax errors in Drupal\Component\Plugin's composer.json, Add test.