It seems that when creating a variant in page manager that it now includes the fields commented below by default:

$handler->conf = array(
  'title' => 'test',
  'no_blocks' => 0,
  'pipeline' => 'standard',
  'body_classes_to_remove' => '',       //This and
  'body_classes_to_add' => '',            // this.
  'css_id' => '',
  'css' => '',
  'contexts' => array(),
  'relationships' => array(),

These are not included in the panopoly_users feature as of now. This is not an issue until another feature tries to override this feature (as in oa_panopoly_users). Since
there is not a 'default' set for the body classes the original feature tries to add the new values from the feature that is doing the overriding. If these are both set (to empty strings) then the issue goes away.

CommentFileSizeAuthor
#1 panopoly_users-body_classes-2209661-1.patch882 bytesscottalan

Comments

scottalan’s picture

scottalan commented
StatusFileSize
new panopoly_users-body_classes-2209661-1.patch882 bytes
lsolesen’s picture

lsolesen commented

Why this change?

-    'panels_breadcrumbs_titles' => 'Log in
+    'panels_breadcrumbs_titles' => 'Log in
 Request Password',
scottalan’s picture

scottalan commented

Not sure why git picked that up as there is actually no change between the lines.

mglaman’s picture

mglaman
Primary language English
Location WI, USA
commented
Status: Active » Needs review 
+++ b/panopoly_users.pages_default.inc
@@ -122,7 +124,7 @@ function panopoly_users_default_page_manager_handlers() {
-    'panels_breadcrumbs_titles' => 'Log in
+    'panels_breadcrumbs_titles' => 'Log in
 Request Password',

This showed up because the IDE probably stripped the extra line at the end of "log in", not sure if this is needed for breadcrumb (or it converted the new line type)

  • dsnopek committed 2402c44 on 7.x-1.x 
    Update Panopoly Users for #2209661 by scottalan: Fixed Panopoly Users -...
dsnopek’s picture

dsnopek
he/him
Primary language English
Location USA
commented
Status: Needs review » Fixed

These changes appear to be totally harmless and I did drush fu a couple times and everything stuck. So, I'm just going to commit this!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.