Updated: Comment #0

Problem/Motivation

Fields can specify indexes and foreign keys in their schema, but not unique keys. Specifically UUID fields should specify a unique key for their column.

Proposed resolution

Allow fields to specify unique keys.

Remaining tasks

User interface changes

-

API changes

CommentFileSizeAuthor
#21 2209049-21-field-schema-unique-keys.patch17.14 KBtstoeckler
#21 2209049-19-21-interdiff.txt1.36 KBtstoeckler
#19 2209049-19-field-schema-unique-keys.patch16.12 KBtstoeckler
#19 2209049-15-19-interdiff-2.txt11.91 KBtstoeckler
#19 2209049-15-19-interdiff.txt876 byteststoeckler
#16 interdiff.txt931 byteslokapujya
#15 2209049-15.patch5.09 KBlokapujya
#13 2209049-13.patch5.08 KBlokapujya
#11 2209049-11.patch5.08 KBlokapujya
#8 2209049-8-field-schema-unique-keys.patch5.31 KBtstoeckler
#4 2209049-4-field-unique-keys.patch5.36 KBtstoeckler
#4 2209049-1-4-interdiff.txt617 byteststoeckler
#1 2209049-1-field-unique-keys.patch4.76 KBtstoeckler

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Active » Needs review
StatusFileSize
new 2209049-1-field-unique-keys.patch4.76 KB

Here we go. Let's see how badly this breaks.

Status: Needs review » Needs work

The last submitted patch, 1: 2209049-1-field-unique-keys.patch, failed testing.

The last submitted patch, 1: 2209049-1-field-unique-keys.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new 2209049-1-4-interdiff.txt617 bytes
new 2209049-4-field-unique-keys.patch5.36 KB

Nice, that looks solvable...

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Related issues: +#2183231: Make ContentEntityDatabaseStorage generate static database schemas for content entities
tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

4: 2209049-4-field-unique-keys.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 4: 2209049-4-field-unique-keys.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
Related issues: -#2183231: Make ContentEntityDatabaseStorage generate static database schemas for content entities
StatusFileSize
new 2209049-8-field-schema-unique-keys.patch5.31 KB

No merge conflict, so must have been a context change.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

8: 2209049-8-field-schema-unique-keys.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 8: 2209049-8-field-schema-unique-keys.patch, failed testing.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs work » Needs review
StatusFileSize
new 2209049-11.patch5.08 KB

Status: Needs review » Needs work

The last submitted patch, 11: 2209049-11.patch, failed testing.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs work » Needs review
StatusFileSize
new 2209049-13.patch5.08 KB

Status: Needs review » Needs work

The last submitted patch, 13: 2209049-13.patch, failed testing.

lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
Status: Needs work » Needs review
StatusFileSize
new 2209049-15.patch5.09 KB
lokapujya’s picture

lokapujya
Primary language English
Location Boston
commented
StatusFileSize
new interdiff.txt931 bytes

interdiff from last patch.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

Awesome @lokapujya, thanks a lot!

Anyone want to RTBC?

blueminds’s picture

blueminds commented
Status: Needs review » Needs work 
+++ b/core/lib/Drupal/Core/Entity/ContentEntityDatabaseStorage.php
@@ -1207,6 +1207,14 @@ public static function _fieldSqlSchema(FieldConfigInterface $field, array $schem
+    foreach ($schema['unique keys'] as $unique_keý_name => $columns) {

$unique_key_name has accent mark on the "y" letter.

Otherwise looks fine.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new 2209049-15-19-interdiff.txt876 bytes
new 2209049-15-19-interdiff-2.txt11.91 KB
new 2209049-19-field-schema-unique-keys.patch16.12 KB

Wow @blueminds, nice catch!

Now that #2183231: Make ContentEntityDatabaseStorage generate static database schemas for content entities is in, we can also remove the hardcoded adding of the UUID unique key from ContentEntitySchemaHandler. Also added test coverage for field unique keys now, completing the test coverage of ContentEntitySchemaHandler.

That revealed a small bug of sorts where defaults weren't applied correctly to the table schema.

Status: Needs review » Needs work

The last submitted patch, 19: 2209049-19-field-schema-unique-keys.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review
StatusFileSize
new 2209049-19-21-interdiff.txt1.36 KB
new 2209049-21-field-schema-unique-keys.patch17.14 KB

Let's see if this is green.

blueminds’s picture

blueminds commented
Status: Needs review » Reviewed & tested by the community

Went through the code, applied, tested, works, looks good.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed c63692f and pushed to 8.x. Thanks!

  • Commit c63692f on 8.x by alexpott: 
    Issue #2209049 by tstoeckler, lokapujya: Allow field schemas to contain...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.