I'm getting

Notice: Undefined variable: label_element in form_process_table() (line 1855 of core\includes\form.inc).

Trivial patch coming up...

CommentFileSizeAuthor
#1 form_process_table-notice.2208793.1.patch679 bytessalvis
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
FileSize
form_process_table-notice.2208793.1.patch679 bytes
salvis’s picture

salvis
he/his
CreditAttribution: salvis commented
Status: Active » Needs review

Just add a missing isset().

Cameron Tod’s picture

Cameron Tod CreditAttribution: Cameron Tod commented
Status: Needs review » Reviewed & tested by the community

I'm surprised these functions are still in use. Patch looks good :)

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

Thanks, cam8001!

Here's where the notice came up...

#2208597-14: Devel HEAD broken: Update calls to config(), drupal_map_assoc, Drupal\Core\Mail\PhpMail
(EDIT: fixed the link)

... and caused Devel to remain broken even after catching up with D8.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

yep, this could not be set, but probably needs test and update doc-block to prevent this case

salvis’s picture

salvis
he/his
CreditAttribution: salvis commented

I don't think so. There's already an 'if' to check whether it's set or not, the condition just isn't quite up to the standard.

So it seems to be valid both ways.

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Reviewed & tested by the community » Fixed

Committed to 8.x. Thanks.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.