While working on a key value entity storage, I found out that getClass() cannot be overridden by any subclasses.

CommentFileSizeAuthor
#4 entity-2208611-4.patch1.33 KBtim.plunkett
#2 entity-2208611-2.patch1.37 KBtim.plunkett
#1 entity-2208611-1.patch698 bytestim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
Issue tags: +KV Entity Storage
FileSize
entity-2208611-1.patch698 bytes
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
entity-2208611-2.patch1.37 KB 
+++ b/core/lib/Drupal/Core/Entity/Query/QueryBase.php
@@ -212,7 +212,7 @@ public function range($start = NULL, $length = NULL) {
     // As the factory classes hardwire QueryBase::getClass, it needs to be
     // hardwired here too.

Well I totally blew past this comment here... But that is only true for the Sql implementation! So let's move the comment.

msonnabaum’s picture

msonnabaum CreditAttribution: msonnabaum commented

Definitely seems like an improvement, but it's still a bit unclear why the second example is hardcoded.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
entity-2208611-4.patch1.33 KB

Yeah no idea. Why not?

msonnabaum’s picture

msonnabaum CreditAttribution: msonnabaum commented
Status: Needs review » Reviewed & tested by the community

Yeah, seems legit.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: +Quick fix

Thanks!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.