Replace usage of views deprecated functions in views

Impressive work. +1 subscribe

Fixed the test fail and cleaned up some more uses of deprecated functions.

I also noticed there are some other apparently unused functions such as views_process_check_options(), views_get_view_result() and views_ui_load() but I guess removing these should be outside the scope of this issue?

Posted #2208893: Remove unused functions from Views as a followup to the above

Could we actually remove the deprecated functions here as well? All we would need is a few more lines in the patch, and a change notice?

On the longrunt it would be great to rewrite the Views helper to be properly injectable, but this is for sure out of scope of this issue

+++ b/core/modules/views/tests/Drupal/views/Tests/Plugin/display/PathPluginBaseTest.php
@@ -281,13 +281,3 @@ protected function setupViewExecutableAccessPlugin() {
-}
-
-namespace {
-  if (!function_exists('views_get_enabled_display_extenders')) {
-    function views_get_enabled_display_extenders() {
-      return array();
-    }
-  }
-}

<3

2208165-views-replace-deprecated-3.patch no longer applies.

error: patch failed: core/modules/views_ui/lib/Drupal/views_ui/Tests/DisplayTest.php:186
error: core/modules/views_ui/lib/Drupal/views_ui/Tests/DisplayTest.php: patch does not apply

Rerolled, parts of DisplayTest moved to DisplayTestCRUD.

11: 2208165-views-replace-deprecated-11.patch queued for re-testing.

Back to RTBC

Committed/pushed to 8.x, thanks!