Convert element_info() to a service

1. +++ b/core/lib/Drupal/Core/Utility/ElementInfo.php
   @@ -0,0 +1,68 @@
   +namespace Drupal\Core\Utility;
   

   I'm wondering if this should live in the Drupal\Core\Render namespace or something instead?

2. +++ b/core/lib/Drupal/Core/Utility/ElementInfo.php
   @@ -0,0 +1,68 @@
   +} ¶
   

   meh

1. +++ b/core/tests/Drupal/Tests/Core/Render/ElementInfoTest.php
   @@ -0,0 +1,121 @@
   +   * @covers ::__construct
   

   I guess that is strictly true, seems weird to have @covers for a non-test method though.

2. +++ b/core/tests/Drupal/Tests/Core/Render/ElementInfoTest.php
   @@ -0,0 +1,121 @@
   +} ¶
   

   Oh, I am sorry. HA

1. +++ b/core/lib/Drupal/Core/Render/ElementInfo.php
   @@ -0,0 +1,70 @@
   + * Contains \Drupal\Core\Utility\ElementInfo.
   

   this is a lie:P

2. +++ b/core/lib/Drupal/Core/Render/ElementInfo.php
   @@ -0,0 +1,70 @@
   + */
   +class ElementInfo {
   

   i guess it would be nice to have an interface:)

3. +++ b/core/tests/Drupal/Tests/Core/Render/ElementInfoTest.php
   @@ -0,0 +1,129 @@
   +   * @covers ::__construct
   +   */
   +  protected function setUp() {
   

   oh, thats nice trick!

Mostly docs fixes, and ElementInfo::buildInfo() is now purer by returning the info rather than setting it itself. Might make it more reusable in the future, and more easily testable.

1. +++ b/core/includes/common.inc
   @@ -4466,25 +4466,12 @@ function drupal_render_cid_create($elements) {
   + * @deprecated As of Drupal 8.0, use \Drupal::service('element_info')->getInfo()
   + *   instead.
   

   If we are deprecating it, don't we need an issue (novice) for removing that to reference here?

2. +++ b/core/tests/Drupal/Tests/Core/Render/ElementInfoTest.php
   @@ -0,0 +1,130 @@
   +   * @var ElementInfoInterface
   

   Full namespace needed.

3. +++ b/core/tests/Drupal/Tests/Core/Render/ElementInfoTest.php
   @@ -0,0 +1,130 @@
   +  public function providerTestGetInfo() {
   

   Nice coverage.

If we are deprecating it, don't we need an issue (novice) for removing that to reference here?

Will do.

I talked to Wim Leers about the idea of renaming this to a generic render service, where we can potentially move code like drupal_render() and Element::children() as well, because a service with one method is silly and all these things belong to the same render API. What do you think?

11: drupal_2207743_11.patch queued for re-testing.

Doesn't look like this needs work at all.

Re-roll.

RTBC if tests pass.

@todo for an issue summary :) therefore needs work

Awesome!

Thanks for the change record draft!

Committed d196e8f and pushed to 8.x. Thanks!