Updated: Comment #N

Problem/Motivation

We have duplicated code in all 6 handler types for broken handlers. They all add the same - basically a default form and label containing details about the missing handler.

Proposed resolution

Use a trait for all of these instead. Then we only need to maintain the code in one place and not 6 - win.

Remaining tasks

User interface changes

None

API changes

None

CommentFileSizeAuthor
#3 interdiff-2206809-3.txt2.01 KBdamiankloip
#3 2206809-3.patch18.6 KBdamiankloip
vdc.BrokenHandlerTrait.patch18.6 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Status: Needs review » Needs work

The last submitted patch, vdc.BrokenHandlerTrait.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review

vdc.BrokenHandlerTrait.patch queued for re-testing.

ImagefieldDisplayTest strikes again.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
FileSize
2206809-3.patch18.6 KB
interdiff-2206809-3.txt2.01 KB

Updated docs

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

Awesome!!!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Very nice. Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

YesCT’s picture

YesCT CreditAttribution: YesCT commented
Related issues: +#2134513: [policy, no patch] Trait strategy