Updated: Comment #N

Problem/Motivation

CKEditor module provides a ckeditor.languages cache bin (name does not conform to all other bin either :p). This seems overkill to have a bin to store one cache entry, which is a language list. This is not even a large cache entry.

Proposed resolution

Remove this cache bin. This one cache item can happily live in the standard 'cache' bin (Same as ckeditor_plugins cache etc...).

Remaining tasks

Review

User interface changes

None

API changes

None

CommentFileSizeAuthor
#1 2205897.patch1.72 KBdamiankloip

Comments

damiankloip’s picture

StatusFileSize
new1.72 KB
berdir’s picture

Status: Needs review » Reviewed & tested by the community

Yep, definitely overkill :)

damiankloip’s picture

Issue summary: View changes
damiankloip’s picture

Issue tags: +Quick fix

Surely.

wim leers’s picture

Assigned: Unassigned » gábor hojtsy

I raised this same concern when this was added, at #2050097-36: Map CKEditor languages to Drupal languages.2. Gábor said (at #38 in that issue): technically this is a cache and ckeditor module owns it; I don't see a problem with that.

I think this change is ok, but let's make sure.

damiankloip’s picture

Ok cool, but we are trying to re organize how we deal with cache bin storage. Which means have a bin just for one entry that hardly changes IS kind of ridiculous :)

gábor hojtsy’s picture

Yeah this looks fine. I agree having a cache bin for only one item that is not even that big is overkill :)

wim leers’s picture

Alrighty, looks like RTBC++ from Gábor and myself then :)

wim leers’s picture

Assigned: gábor hojtsy » Unassigned
catch’s picture

Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.