Wins the record for the Most ambiguous issue title ever. :P

CommentFileSizeAuthor
#7 2205161-convert-node-js-7.patch1.38 KBjibran
#7 interdiff.txt1.47 KBjibran
#5 2205161-convert-node-js-5.patch1.55 KBjibran
#5 interdiff.txt590 bytesjibran
#1 2205161-convert-node-js-1.patch1.58 KBrteijeiro

Comments

rteijeiro’s picture

rteijeiro commented
Status: Active » Needs review
StatusFileSize
new 2205161-convert-node-js-1.patch1.58 KB

I think this is correct :-/

At first I thought we were using nodejs in Drupal 8 xD

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

+1

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs review

Sorry, this should wait until the parent issue has landed

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Needs work

#2203407: Replace #attached library array values with provider-namespaced strings has landed, so this needs a re-roll now.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs work » Needs review
StatusFileSize
new interdiff.txt590 bytes
new 2205161-convert-node-js-5.patch1.55 KB

Reroll.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented

Hah, it's weird to see that the library is declared already ;-)

As in #2205155: Convert custom_block.js into a library, each of the wrapping vertical tab containers depends on #access, so we simply want to replace each of the #attached instance.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
StatusFileSize
new interdiff.txt1.47 KB
new 2205161-convert-node-js-7.patch1.38 KB

Fixed #6.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks!

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

(heh @ issue title)

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.