Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.Wins the record for the Most ambiguous issue title ever. :P
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | 2205161-convert-node-js-7.patch | 1.38 KB | jibran |
| #7 | interdiff.txt | 1.47 KB | jibran |
| #5 | 2205161-convert-node-js-5.patch | 1.55 KB | jibran |
| #5 | interdiff.txt | 590 bytes | jibran |
| #1 | 2205161-convert-node-js-1.patch | 1.58 KB | rteijeiro |
Comments
Comment #1
rteijeiro commentedI think this is correct :-/
At first I thought we were using nodejs in Drupal 8 xD
Comment #2
dawehner+1
Comment #3
sunSorry, this should wait until the parent issue has landed
Comment #4
sun#2203407: Replace #attached library array values with provider-namespaced strings has landed, so this needs a re-roll now.
Comment #5
jibranReroll.
Comment #6
sunHah, it's weird to see that the library is declared already ;-)
As in #2205155: Convert custom_block.js into a library, each of the wrapping vertical tab containers depends on #access, so we simply want to replace each of the #attached instance.
Comment #7
jibranFixed #6.
Comment #8
sunThanks!
Comment #9
webchickCommitted and pushed to 8.x. Thanks!
(heh @ issue title)