Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
documentation
Priority:
Normal
Category:
Bug report
Assigned:
Issue tags:
Reporter:
Created:
25 Feb 2014 at 16:32 UTC
Updated:
29 Jul 2014 at 23:24 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
jhodgdonThanks! Needs to be fixed in 8.x first, then backported to 7.x. (Or more likely the same patch can be used for both, since the functions appear to be identical).
Comment #2
sandipmkhairnar commentedUpdated code as per comments.
Comment #3
sandipmkhairnar commentedComment #4
sandipmkhairnar commentedComment #5
jhodgdonThanks... but:
We lost the information here about what the function does, which is to set up to render a menu tree. This statement is what a lot of functions do (return a render array), not specific to what this function does (do that for a menu tree).
And really, the @return already talks about the structure of the returned value. So ... Maybe the first line should say something more like:
Creates an output structure for rendering a menu tree.
or something similar?
Comment #6
sandipmkhairnar commentedComment #7
sandipmkhairnar commentedComment #8
jhodgdonThanks!
Comment #9
alexpottCommitted 29b519c and pushed to 8.x. Thanks!
Comment #10
jhodgdonCommitted the same patch (with a little fuzz) also to 7.x. Thanks!