Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#9 | views-handler-2204635-9-interdiff.txt | 5.31 KB | Berdir |
#9 | views-handler-2204635-9.patch | 7.56 KB | Berdir |
#6 | views-handler-2204635-6-interdiff.txt | 620 bytes | Berdir |
#6 | views-handler-2204635-6.patch | 7.19 KB | Berdir |
#1 | views-handler-2204635-1.patch | 7.19 KB | Berdir |
Comments
Comment #1
BerdirSeems easy enough :)
Dropped the ViewsDiscoveryHandler thing.
Comment #2
tim.plunkettI think there were other issues about improving ViewsHandlerManager, but I can't find them, and this is fine.
Getting rid of ViewsHandlerDiscovery is especially nice. That used to contain a lot more logic, but using $this->defaults is much nicer.
Comment #3
damiankloip CreditAttribution: damiankloip commentedSorry, this changes 'plugin_type' to 'plugin'.
Otherwise, this patch look great. Moving stuff to the defaults is indeed a much nicer thing.
Comment #4
tim.plunkettWhoops. But wait, why did it pass?!
Comment #5
damiankloip CreditAttribution: damiankloip commentedWe don't really use it.
Comment #6
BerdirA feature that's not covered by tests doesn't exist ;)
Comment #7
damiankloip CreditAttribution: damiankloip commentedIt's not really a feature. Its just something that's there :)
Comment #8
damiankloip CreditAttribution: damiankloip commentedYes, this is RTBC.
Comment #9
BerdirUpdated for #2053153: Allow contrib modules to provide plugins on behalf of optional modules.
Comment #10
damiankloip CreditAttribution: damiankloip commentedAnd again..
Comment #11
damiankloip CreditAttribution: damiankloip commented9: views-handler-2204635-9.patch queued for re-testing.
Comment #12
dawehnerThis improves DX (maybe this helps to get this in faster)
Comment #13
alexpottCommitted 1d1c63d and pushed to 8.x. Thanks!