Sub-Task from #2010412: [Meta] Change plugin managers to use DefaultPluginManager.

CommentFileSizeAuthor
#9 views-handler-2204635-9-interdiff.txt5.31 KBberdir
#9 views-handler-2204635-9.patch7.56 KBberdir
#6 views-handler-2204635-6-interdiff.txt620 bytesberdir
#6 views-handler-2204635-6.patch7.19 KBberdir
#1 views-handler-2204635-1.patch7.19 KBberdir

Comments

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Active » Needs review
StatusFileSize
new views-handler-2204635-1.patch7.19 KB

Seems easy enough :)

Dropped the ViewsDiscoveryHandler thing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community
Issue tags: +VDC, +Plugin system

I think there were other issues about improving ViewsHandlerManager, but I can't find them, and this is fine.
Getting rid of ViewsHandlerDiscovery is especially nice. That used to contain a lot more logic, but using $this->defaults is much nicer.

damiankloip’s picture

damiankloip commented
Status: Reviewed & tested by the community » Needs work 
+++ b/core/modules/views/lib/Drupal/views/Plugin/ViewsHandlerManager.php
@@ -45,18 +44,23 @@ class ViewsHandlerManager extends PluginManagerBase {
+      'plugin' => $handler_type,

Sorry, this changes 'plugin_type' to 'plugin'.

Otherwise, this patch look great. Moving stuff to the defaults is indeed a much nicer thing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

Whoops. But wait, why did it pass?!

damiankloip’s picture

damiankloip commented

We don't really use it.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Needs work » Needs review
StatusFileSize
new views-handler-2204635-6.patch7.19 KB
new views-handler-2204635-6-interdiff.txt620 bytes

A feature that's not covered by tests doesn't exist ;)

damiankloip’s picture

damiankloip commented

It's not really a feature. Its just something that's there :)

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

Yes, this is RTBC.

berdir’s picture

berdir
Primary language German
Location Switzerland
commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new views-handler-2204635-9.patch7.56 KB
new views-handler-2204635-9-interdiff.txt5.31 KB

Updated for #2053153: Allow contrib modules to provide plugins on behalf of optional modules.

damiankloip’s picture

damiankloip commented
Status: Needs review » Reviewed & tested by the community

And again..

damiankloip’s picture

damiankloip commented

9: views-handler-2204635-9.patch queued for re-testing.

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +DX (Developer Experience)

This improves DX (maybe this helps to get this in faster)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 1d1c63d and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.