Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
theme system
Priority:
Normal
Category:
Task
Assigned:
Issue tags:
Reporter:
Created:
23 Feb 2014 at 19:19 UTC
Updated:
29 Jul 2014 at 23:23 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
sunPicturefill is actually a bit weird — does anyone know why we diverged from upstream, instead of contributing upstream?
Comment #2
sunLet's ignore the topic of #1 here and discuss that in #2203431: [meta] Various asset (JavaScript) libraries have to be updated to a (minified) stable release prior to 8.0.0 instead.
Attached patch moves both libraries into core.
Comment #3
wim leersAgreed.
Any reason why we don't move CKEditor and others here already? :)
Comment #4
sunI added explicit @todos to the new .libraries.yml files in the original conversion. These two libraries are the only two that are not in
/core/assets/vendoryet. All others are in there already.The declaration of the
ckeditorlibrary was moved intocore.libraries.ymlin the parent/original issue already.Thus, moving these two is all that is required to resolve this issue.
Comment #5
sunComment #6
sunAny additional questions? :-)
Comment #7
wim leerslgtm
Comment #8
webchickI guess this works. It's a little weird for something in a super optional core module (Tour) to be in "core" core library definitions, though.
This solution obviously won't work for contrib, either, since contrib modules can't hack core.services.yml (beyond hook_library_info_alter() I suppose...), and we don't have a central "contrib.services.yml" to ensure one library registration per Drupal installation. So it's not clear to me how contrib is going to avoid all of the problems listed in the issue summary when for example both Views Slideshow and Media module want to use different versions of the same slider library. I guess we'll need thin module wrappers around every JS lib out there and these modules to declare dependencies on them?
At any rate, though, this hack will work for the libraries used by core, and it sounds like we've already started doing this anyway w/ CKEditor, which is also a dependency of an optional core module, so this is just making all the other libraries consistent with this approach.
Committed and pushed to 8.x.