Warnings in commons_trusted_contacts during drush site install [#2203231]

Seeing a repeat of these warnings during drush site install ..

drush site-install --site-name=Commons --account-name=admin --account-pass=admin--account-mail=test@test.com --site-mail=test@test.com -y commons commons_anonymous_welcome_text_form.commons_anonymous_welcome_title="Hello" commons_anonymous_welcome_text_form.commons_anonymous_welcome_body="Body" commons_create_first_group.commons_first_group_title="Internet People" commons_create_first_group.commons_first_group_body="This is the first group on the page."

Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                                [warning]
/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                            [warning]
/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).

Comment	File	Size	Author
#7	2203231-commons-entity-info-cache-7.patch	2.63 KB	japerry
#4	commons-trusted-contacts-warnings-2203231-4.patch	2.04 KB	joelstein
#1	aegir-commons-error.txt	39.14 KB	stieglitz

Comments

Comment #1

stieglitz commented 4 March 2014 at 18:45

Status	File	Size
new	aegir-commons-error.txt	39.14 KB

I ran into this on an aegir server as well causing a failure. Here is a portion of the output report:

array_keys() expects parameter 1 to be array, null given commons_trusted_contacts.module:17
Invalid argument supplied for foreach() commons_trusted_contacts.module:17
Undefined index: node commons_trusted_contacts.features.field_instance.inc:509
array_keys() expects parameter 1 to be array, null given commons_trusted_contacts.features.field_instance.inc:509
Invalid argument supplied for foreach() commons_trusted_contacts.features.field_instance.inc:509
Undefined index: node commons_trusted_contacts.module:17
array_keys() expects parameter 1 to be array, null given commons_trusted_contacts.module:17
Invalid argument supplied for foreach() commons_trusted_contacts.module:17
WD acquia spi: Connect your site to a valid subscription on the Acquia Network to send SPI data
Undefined index: node commons_trusted_contacts.features.field_instance.inc:509
array_keys() expects parameter 1 to be array, null given commons_trusted_contacts.features.field_instance.inc:509
Invalid argument supplied for foreach() commons_trusted_contacts.features.field_instance.inc:509
Undefined index: node commons_trusted_contacts.module:17
array_keys() expects parameter 1 to be array, null given commons_trusted_contacts.module:17
Invalid argument supplied for foreach() commons_trusted_contacts.module:17

The rest is attached.

Comment #2

stieglitz commented 4 March 2014 at 18:48

Though the aegir-commons site failed. I was able to log in and on the surface it appears to be working.

Comment #3

japerry

KOMK

commented 4 March 2014 at 20:08

Assigned:

Unassigned

» japerry

Confirmed. Looking into it.

Comment #4

joelstein commented 2 April 2014 at 18:04

Status:

Active

» Needs review

Status	File	Size
new	commons-trusted-contacts-warnings-2203231-4.patch	2.04 KB

Here's a patch that fixes the warnings on drush install.

Comment #5

deciphered

English

Ballarat, Victoria, Australia

commented 2 April 2014 at 22:49

Status:

Needs review

» Needs work

This is only a bandaid fix, it prevents the error but doesn't resolve the issue itself.

I've opened a bit of a Meta issue (#2231897: [meta] Issues installing via Drush) and this is one of the issues. Basically what is happening is that during a non-interactive installation (Drush SI) the commons_groups_get_group_content_entity_types() function isn't returning any data, yet it does so during a standard installation.

Comment #6

deciphered

English

Ballarat, Victoria, Australia

commented 2 April 2014 at 22:56

Comment #7

japerry

KOMK

commented 12 June 2014 at 00:30

Status:

Needs work

» Needs review

Status	File	Size
new	2203231-commons-entity-info-cache-7.patch	2.63 KB

1 file was hidden/shown/deleted

Status	File	Size
hidden	commons-trusted-contacts-warnings-2203231-4.patch	2.04 KB

This error is being caused because of a function thats getting cached early on the install process before other commons modules can insert their integrations.

I've added a cache flag so during install trusted contacts doesn't get the missing integrations. Works decent for me when testing.

Comment #8

lsolesen commented 12 June 2014 at 07:11

Issue tags:

-site-install

For me it looks good. I went from this:

vagrant@vlad:/var/www/site/docroot/commons$ drush si commons --account-name=admin --account-pass=admin --db-url=mysql://vlad:wibble@localhost/commons -y
You are about to DROP all tables in your 'commons' database. Do you want to continue? (y/n): y
Starting Drupal installation. This takes a few seconds ...                                                                                                                                                   [ok]
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                           [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                           [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                           [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                           [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                           [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD acquia spi: Connect your site to a valid subscription on the Acquia Network to send SPI data                                                                                                              [error]
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                           [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
WD php: Warning: array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                        [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
WD php: Warning: Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Installation complete.  User name: admin  User password: admin                                                                                                                                               [ok]
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                                             [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                                             [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                                             [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                                             [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                                             [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                            [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
Invalid argument supplied for foreach() in commons_trusted_contacts_field_default_field_instances() (line 509 of                                                                                             [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.features.field_instance.inc).
array_keys() expects parameter 1 to be array, null given in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                         [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).
Invalid argument supplied for foreach() in commons_trusted_contacts_system_info_alter() (line 17 of                                                                                                          [warning]
/var/www/site/docroot/commons/profiles/commons/modules/commons/commons_trusted_contacts/commons_trusted_contacts.module).

After applying the patch I got this:

WD acquia spi: Connect your site to a valid subscription on the Acquia Network to send SPI data                                                                                                              [error]
Installation complete.  User name: admin  User password: admin                                                                                                                                               [ok]

Comment #9

deciphered

English

Ballarat, Victoria, Australia

commented 12 June 2014 at 07:53

It sounds like a sound fix to me. I don't have the time to test to ensure it is 100% fixed, as it is quite a time consuming issue to debug, but it seems reasonable to me.

I won't mark as RTBC myself, but I urge anyone else who is working with commons and has encountered this issue to please consider doing so once they have confirmed if themselves.

Comment #10

12 June 2014 at 17:01

Commit fbdb03c on 7.x-3.x by japerry:

Issue #2203231 by japerry: Add cache flag to entity info hook

Comment #11

lsolesen commented 13 June 2014 at 11:14

Status:

Needs review

» Fixed

@japerry pushed a fix for this.

Comment #12

18 June 2014 at 22:26

Commit 3d36835 on 7.x-3.x by japerry:

Issue #2203231, #1906678 by japerry: Wrap functions that return null...

Comment #13

2 July 2014 at 22:30

Status:

Fixed

» Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

Warnings in commons_trusted_contacts during drush site install

Comments

Comment #1

Comment #2

Comment #3

Comment #4

Comment #5

Comment #6

Comment #7

Comment #8

Comment #9

Comment #10

Comment #11

Comment #12

Comment #13

Related issues

News items

Our community

Documentation

Drupal code base

Governance of community