Problem/Motivation

There's no page title on the module uninstall page.

Proposed resolution

Add a title (and a test).

Remaining tasks

Review and commit. :)

User interface changes

Page title where one was absent.

API changes

n/a

CommentFileSizeAuthor
#1 drupal.uninstall_page_title.2203115.patch1.26 KBtraviscarden
#1 drupal.uninstall_page_title.2203115.test-fail.patch846 bytestraviscarden

Comments

traviscarden’s picture

traviscarden commented
Assigned: traviscarden » Unassigned
Status: Active » Needs review
StatusFileSize
new drupal.uninstall_page_title.2203115.patch1.26 KB
new drupal.uninstall_page_title.2203115.test-fail.patch846 bytes

Attached is a patch that sets the page title to "Uninstall" and a patch that tests for it. Also attached is a patch with only the (failing) test.

Status: Needs review » Needs work

The last submitted patch, 1: drupal.uninstall_page_title.2203115.test-fail.patch, failed testing.

traviscarden’s picture

traviscarden commented
Status: Needs work » Needs review

Of course, the test-only patch was meant to fail. (Did I attach the files in the wrong order?)

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Status: Needs review » Reviewed & tested by the community
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.