content_translation_view_access() is invoked as a hook_ENTITY_TYPE_access() hook implementation

Could we make these names a bit less ambiguous? I'd say hasFooAccess() if they were method names.

Edit: Or maybe content_translation_check_foo_access()?

check...access is fine. I don't have a strong opinion either way. The current patch is equally fine with me.

ha. :P I'm not sure it's actually major, but it sure is weird.

Let's add explicit test coverage for this as well as the implicit coverage coming in #2200229: Use entity access for Views UI routes.

adding link to doc about tests for someone that wants to pick this up.
--
needs review to trigger testbot.
it is still needs work for test coverage.

Xano and I talked about this.

Xano is going to post a little bit more to make clear what needs to be done.

So you could maybe write a test for this with invoking the view access and then expecting an exception? Or would that entirely fail? Without the fix that would fail. Looks like the problem overall is this is never invoked in core. ?!

The current issue is blocking a ton of other more important work, so I don't think it's worth to hold that up just to provide additional coverage, which I completely agree is badly needed. The patch in #1 is ok and it's pretty obvious that it won't introduce any regression as it's just renaming a bunch of functions that may even be deprecated after #2155787: Introduce more flexible access control for content translation operations. The only risk we have here is we are introducing other name clashes, but I guess @xano already properly checked this is not the case :)

Since we are in the middle of a big sprint, I suggest to file a major follow-up to add test-coverage for these (semi-unused) API functions and let @xano go on with the stuff he's working on. If none will show up to work on that I'll do it myself prior to the first D8 stable release, I promise.

Tentatively marking RTBC to get feedback from committers, please see #17-#18.

+++ b/core/modules/content_translation/content_translation.module
@@ -262,7 +262,7 @@ function content_translation_view_access(EntityInterface $entity, $langcode, Acc
-function content_translation_add_access(EntityInterface $entity, Language $source = NULL, Language $target = NULL) {
+function content_translation_access_add(EntityInterface $entity, Language $source = NULL, Language $target = NULL) {

@@ -279,7 +279,7 @@ function content_translation_add_access(EntityInterface $entity, Language $sourc
-function content_translation_edit_access(EntityInterface $entity, Language $language = NULL) {
+function content_translation_access_edit(EntityInterface $entity, Language $language = NULL) {

@@ -295,7 +295,7 @@ function content_translation_edit_access(EntityInterface $entity, Language $lang
-function content_translation_delete_access(EntityInterface $entity, Language $language = NULL) {
+function content_translation_access_delete(EntityInterface $entity, Language $language = NULL) {

Why do we have these unused and untested functions anyway?

If we do need to provide them then they should be tested. And this issue should add that test coverage.

@Xano told me @alexpott is fine with removing the unused functions and merge the offending one directly in the caller. The failures in #23 show that this change is extensively covered so I think we should be good now.

Let's try again :)

git ac https://drupal.org/files/issues/drupal_2200333_25.patch
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  5158  100  5158    0     0   3699      0  0:00:01  0:00:01 --:--:--  6840
error: patch failed: core/modules/content_translation/content_translation.module:251
error: core/modules/content_translation/content_translation.module: patch does not apply

Committed b3df95c and pushed to 8.x. Thanks!

Superb, thanks!