While working on #2136503: Make \Drupal\Core\Path\AliasManager storage independent I found out that we don't use interface with \Drupal\Core\Path\Path. This will make implementation and usage of alternative storage implementations much harder.
Let's introduce PathInterface and use it in all places that currently expect Path class.
Patch follows.
| Comment | File | Size | Author |
|---|---|---|---|
| #19 | drupal_2199381_19.patch | 728 bytes | roderik |
| #15 | interdiff.txt | 1.31 KB | xano |
| #15 | drupal_2199381_15.patch | 13.8 KB | xano |
Comments
Comment #1
slashrsm commentedComment #2
slashrsm commentedComment #3
slashrsm commentedReroll.
Comment #4
dawehnerThis looks perfect. People would argue that we need a change record.
Comment #5
sun+1
Next best step would be to rename both the class + interface to some more appropriate and less confusing name (in a separate issue).
PathHandler, PathManager, PathRepository, or similar. — Anything that doesn't sound like the domain object itself (a "Path") :-)
Comment #6
alexpottThere is no use Drupal\Core\Language\Language.
Comment #7
slashrsm commentedComment #8
slashrsm commentedComment #9
slashrsm commented7: 2199381_7.patch queued for re-testing.
Comment #10
fgmThe patch in #7 appears not to be affected by #2209145: Move all path alias SQL queries to a single storage controller.
Comment #11
slashrsm commented7: 2199381_7.patch queued for re-testing.
Comment #12
xanoDocumentation clean-up.
Comment #13
dawehnerGreat!
Comment #14
alexpottNeed to update the tyephint too
Comment #15
xanoComment #16
dawehnerBack to RTBC
Comment #17
alexpottCommitted 1a51606 and pushed to 8.x. Thanks!
Comment #19
roderikCan I request small followup in the same issue?
I have not looked at the code in this patch closely, but while rerolling something against this, I spotted the following comment...
Comment #20
xanoWell-spotted! However, that code is not related to this issue, so please open another one under the documentation component, so jhodgdon, the documentation maintainer, will find it and commit it to core.
Comment #21
slashrsm commentedYay! :)