Closed (duplicate)
Project:
Drupal core
Version:
8.0.x-dev
Component:
base system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
15 Feb 2014 at 08:39 UTC
Updated:
29 Jul 2014 at 23:22 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
divesh.kumar commentedI'll take on this.
Comment #2
divesh.kumar commentedDavid,
Can you please put on a bit light what exactly needs to be done as I checked the references in the file.module and its looking fine.
Thanks
Comment #3
thedavidmeister commentedThis is what I get when I search for check_plain() in the file module using Sublime Text. There are quite a few calls to check_plain() still.
Comment #4
divesh.kumar commentedPatch attached.
Comment #5
divesh.kumar commentedComment #6
thedavidmeister commentedComment #7
thedavidmeister commentedplease use namespace aliases, see the parent issue for more details.
Comment #8
divesh.kumar commentedI am making changes to all patches I submitted
.
Comment #9
divesh.kumar commentedComment #10
thedavidmeister commentedWhy are we touching this?
Comment #11
divesh.kumar commentedThis may be file encoding error. Let me check it.
Comment #12
thedavidmeister commentedComment #13
divesh.kumar commentedComment #14
ianthomas_ukPatch looks good, applies and catches all uses of check_plain() in the file module.
@divesh.kumar, for future reference the convention is that the second number in a patch filename is the comment number that it would be uploaded to, in this case that would make the filename 2196841-13.patch.
Comment #15
alexpott2196841-3.patch no longer applies.
Comment #16
longwaveRerolled.
Comment #17
ianthomas_ukJust changed context
Comment #18
thedavidmeister commentedComment #19
webchickPlease, no. Can we have just one patch that converts all of these in one go?
Comment #20
thedavidmeister commentedComment #21
ianthomas_ukThis was fixed on the meta