Closed (fixed)
Project:
Nivo Slider
Version:
8.x-1.x-dev
Component:
Code
Priority:
Critical
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Feb 2014 at 20:56 UTC
Updated:
5 Oct 2017 at 15:49 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
pkosenko commentedThis would explain why nivo_slider successfully downloads with Drush but reports having "0 modules" and why it does not display in the extension (modules) page of the most current Drupal 8 (July 2014). I think someone needs to update the nivo_slider project. Here's the Drush output:
$ drush dl nivo_slider
Project nivo_slider (8.x-1.4) downloaded to [success]
c:/Users/me/documents/My Web
Sites/drupal8.1/drupal//modules/nivo_slider.
Project nivo_slider contains 0 modules: .
me@me ~/documents/My Web Sites/drupal8.1/drupal (8.x)
$
Comment #2
rpmskret commentedI am submitting a patch that should prevent this issue.
Comment #4
rpmskret commentedI need some help. I am new to patching. I submitted the patch above after carefully follow advice from Making a drupal patch. I cannot understand why it failed.
Anyone have advice?
Comment #5
Egmund commentedSame problem here: Will not install or show up in 'modules'!!!
Comment #6
clivesj commentedpatch
Comment #7
clivesj commentedComment #9
clivesj commentedComment #11
clivesj commented@Randy. I think your patch is good. In the test results you can see that the patch is tested against version 8.x-1.4. This version does not has a yml file and the test bot can not find it to apply your patch. I have changed the version to 8.x-1.x-dev. My patch is postponed because 8.x-1.x does not have a valid test.
Comment #12
rpmskret commented@Joop (clivesj): Thank you for your comment. It was my first drupal patch try and I was very disappointed as I followed drupal patching procedures and the patch was very simple. If you are going to be contributing further with the nivo_slider project I could provide my code which worked with a fresh drupal 8 install about a month ago. Let me know if so.
Comment #13
clivesj commentedThanks Randy. Once more: your patch was good, but the version number for this issue was set to 8.x-1.4. So the testbot uses the wrong nivo_slider version to check your patch (should be 8.x-1.x-dev).
Yes, I just offered the maintainer my help to get the module ahead. So if you don't mind you can sent me the code indeed. Please indicate if it works with drupal beta. There are a lot of changes in the first D8Beta version.
Comment #14
deggertsen commentedInterested in an update here...
Comment #15
caspervoogt commentedI tried Randy's patch and that did solve the issue with the module not appearing in the module manager.
Comment #16
dziemecki commentedI was able to get it to register in the modules list by renaming the "nivo_slider.info" file to "nivo_slider.info.yml" and by completely changing the contents:
Comment #17
kentek314 commentedI copied dziemecki text but still no joy.
How can I register without Drush (I'm on a win10 box) and get the module to register?
Comment #18
hottaco commentedUsing the latest dev version, editing the info.yml file and pasting the contents of #16 worked for me. After flushing caches.
Comment #19
Christophe Bourgois commented#16 worked for me and version 8.x-1.x-dev
But admin/structure/nivo-slider gives me a 404 page not found
Comment #20
andrtroe commentedComment #21
andrtroe commentedFixed in dev version. Thanks to all.