Problem/Motivation

#2175917: Clean up configuration system events introduced the Drupal\Core\Config\ConfigEvents class which defines configuration event names. RoutingEvents and KernelEvents classes contain similar event definitions, but these classes are defined as 'final' class and ConfigEvents is not.

Proposed resolution

Make ConfigEvents a final class.

Remaining tasks

T.b.d.

User interface changes

none

API changes

none

CommentFileSizeAuthor
#1 config-final-class-2195407-1.patch437 bytessutharsan

Comments

sutharsan’s picture

sutharsan commented
Status: Active » Needs review
StatusFileSize
new config-final-class-2195407-1.patch437 bytes
alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Needs review » Reviewed & tested by the community

Yep makes heaps of sense.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented 
+++ b/core/lib/Drupal/Core/Config/ConfigEvents.php
@@ -10,7 +10,7 @@
  * Defines events for the configuration system.

Please also update this so that it describes the appropriate changes.

jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented

What I meant was please update the comment why this class is final. I have looked at other final classes in core and all has simple description so we don't have to update the comment. Please ignore #3. RTBC +1.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.