This discussion branches off of this issue to add the ability to reference external Javascript files using drupal_add_js.

This issue tracks the ability to cache these external Javascript files.

CommentFileSizeAuthor
#5 219346.patch2.57 KBRobLoach
Members fund testing for the Drupal project. Drupal Association Learn more

Comments

RobLoach’s picture

Status: Active » Postponed

Drupal_add_js() has to get external javascript support first.

Wim Leers’s picture

Subscribing. This is a must for better page loading performance.

davidtrainer’s picture

This is an important enhancement for Translatable Comments.

RobLoach’s picture

Status: Postponed » Closed (duplicate)

Moved to the reinvention of drupal_add_js: http://drupal.org/node/251578#comment-871405

RobLoach’s picture

Status: Closed (duplicate) » Needs work
Issue tags: +JavaScript, +Patch Spotlight
FileSize
2.57 KB

Would be good to have SimpleTests......

Also have to figure out what to do if the file doesn't return a successful return code.

hass’s picture

For caching external files it is *very* important to have an auto clean-up feature. Additional you need to wipe the locally cached files if the clean up button is clicked on performance page. You can find an example for the auto clean-up in the Google Analytics module... the remote and locally cached file can change and therefore it will be deleted after one day and downloaded again if requested first. I think this is basic functionality for this caching feature and needs to be added to the above code.

xjm’s picture

Tracking.

Wim Leers’s picture

Status: Needs work » Closed (fixed)

Cleaning up the issue queue.

vasrush’s picture

Hope that this will help other D6 users

http://drupal.org/project/cache_external_files

philbar’s picture

Status: Closed (fixed) » Needs work

Did #5 and #6 get addressed?

nod_’s picture

Version: 7.x-dev » 8.x-dev
Status: Needs work » Postponed

I'm worried this will introduce a lot of problems. Hopefully when JS processing will be pluggable it'll be easy to add for contrib.

nod_’s picture

Version: 8.x-dev » 9.x-dev
Status: Postponed » Needs work

Let's not deal with cache invalidation of remote scripts in core for D8.

catch’s picture

Version: 9.x-dev » 8.1.x-dev
Issue summary: View changes
Issue tags: -Patch Spotlight +front end performance

I have a 6.x module that does this: https://www.drupal.org/project/asset_cache

We could add this in a minor version if we wanted to.

YesCT’s picture

making tag the more common one so we can delete the lesser used one so it does not show in the autocomplete

nod_’s picture

Status: Needs work » Active

Version: 8.1.x-dev » 8.2.x-dev

Drupal 8.1.0-beta1 was released on March 2, 2016, which means new developments and disruptive changes should now be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.2.x-dev » 8.3.x-dev

Drupal 8.2.0-beta1 was released on August 3, 2016, which means new developments and disruptive changes should now be targeted against the 8.3.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

Version: 8.4.x-dev » 8.5.x-dev

Drupal 8.4.0-alpha1 will be released the week of July 31, 2017, which means new developments and disruptive changes should now be targeted against the 8.5.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.