Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
entity system
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
8 Feb 2014 at 10:06 UTC
Updated:
29 Jul 2014 at 23:21 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
berdirThis should be it, added the implements QueryInterface to QueryBase, otherwise those methods aren't connected to the interface but the docblocks says it does.
Comment #4
sandykadam commented1: query-get-entity-type-id-2191651-1.patch queued for re-testing.
Comment #6
berdir1: query-get-entity-type-id-2191651-1.patch queued for re-testing.
Comment #7
dawehnerThis looks solid.
Comment #8
berdirHm, let's do a bit more here :)
This patches changes the constructor to EntityTypeInterface, which was the only reason we needed entityManager, so we can remove that.
And it does the same for EntityQueryFactoryInterface and the Sql and Config factory, there is no need to pass around the entity manager there either, it's a service, and if a specific factory or query implementation needs the entity manager, they can always inject that directly into themself.
Comment #9
sandykadam commented@Berdir Looks good to me.
Comment #10
xjmLooks like https://drupal.org/node/2185427 covers this API change already, so should we just add a reference to this issue on that change record?
Comment #11
alexpottNice! Committed fcb52a6 and pushed to 8.x. Thanks!