Updated: Comment #N

Problem/Motivation

Follow-up of #2165155: Change $entity_type to $entity_type_id and $entity_info to $entity_type/$entity_types and other issues dedicated to cleaning up after $entity_info => EntityTypeInterface.

Looks like we missed one getEntityType()...

Proposed resolution

Rename that method.

Remaining tasks

User interface changes

API changes

Comments

berdir’s picture

Status: Active » Needs review
StatusFileSize
new2.01 KB

This should be it, added the implements QueryInterface to QueryBase, otherwise those methods aren't connected to the interface but the docblocks says it does.

Status: Needs review » Needs work

The last submitted patch, 1: query-get-entity-type-id-2191651-1.patch, failed testing.

The last submitted patch, 1: query-get-entity-type-id-2191651-1.patch, failed testing.

sandykadam’s picture

Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1: query-get-entity-type-id-2191651-1.patch, failed testing.

berdir’s picture

Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

This looks solid.

berdir’s picture

Status: Reviewed & tested by the community » Needs review
StatusFileSize
new18 KB

Hm, let's do a bit more here :)

This patches changes the constructor to EntityTypeInterface, which was the only reason we needed entityManager, so we can remove that.

And it does the same for EntityQueryFactoryInterface and the Sql and Config factory, there is no need to pass around the entity manager there either, it's a service, and if a specific factory or query implementation needs the entity manager, they can always inject that directly into themself.

sandykadam’s picture

Status: Needs review » Reviewed & tested by the community

@Berdir Looks good to me.

xjm’s picture

Looks like https://drupal.org/node/2185427 covers this API change already, so should we just add a reference to this issue on that change record?

alexpott’s picture

Status: Reviewed & tested by the community » Fixed

Nice! Committed fcb52a6 and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.