Text module is not required, but is marked as required

If string field type will get widget and formatter it would be much easy #2150511: [meta] Deduplicate the set of available field types

drupal8.text-required.0.patch queued for re-testing.

I verified that all modules that call text_summary() or create text fields have the dependency on text.module.

Together with #1541298: Remove Node module dependency from Testing profile, this will remove node, filter and text from the list of modules that every web test needs to enable.

Based on a quick test, this decreased the run time of UserSaveTest from 6 to 5 seconds for me, but that wasn't a very scientific test :)

6: 2191285.6.patch queued for re-testing.

6: 2191285.6.patch queued for re-testing.

Nice, now that #1541298: Remove Node module dependency from Testing profile has been committed, tests are now actually running without node, text and filter for the very first time, and that's causing fails related to filter.module as well. Shows that the issue to make filter.module should have waited for this, but I think we can fix it here.

Looks like file.module calls _filter_htmlcorrector() directly, so it needs a dependency on that. Trying again, hopefully with better readable results.

This will need a change record based on #1934772-39: Filter module is not required, but is marked as required.

https://drupal.org/node/1397856 is the change record to look at.

11: 2191285.11.patch queued for re-testing.

Nice, now we have some real test fails that show that filter.module can actually *not* be an optional module, as there are for example calls to _filter_htmlcorrector() in mail.inc :)

Looking at that, should we move that function to Utility\Xss?

So is Utility\String a suitable place? The four functions in there all handle HTML already.

#2195745: Replace _filter_htmlcorrector() with a utility class in core is in.

Nous allons ici.

11: 2191285.11.patch queued for re-testing.

I always avoid to run that locally

What is the reason?

The reason is that it takes forever to run ;)

I'll have a look later today I hope.

Is the dependency for file module still necessary? I only added that due to the call to _filter_htmlcorrector(), before seeing the other calls and we fixed that.

+++ b/core/modules/contact/contact.info.yml
@@ -5,3 +5,5 @@ package: Core
+dependencies:
+  - text

Will be after #1856562: Convert "Subject" and "Message" into Message base fields

Fix latest test
PS: it's easy to comment-out passed test* and leave only one that was broken, so it takes 42 sec for me.

1. +++ b/core/modules/config/lib/Drupal/config/Tests/ConfigSingleImportExportTest.php
   @@ -128,7 +128,7 @@ public function testExport() {
        // Spot check several known simple configuration files.
        $element = $this->xpath('//select[@name="config_name"]');
        $options = $this->getAllOptions($element[0]);
   -    $expected_options = array('filter.settings', 'system.site', 'user.settings');
   +    $expected_options = array('system.site', 'user.settings');
        foreach ($options as &$option) {
          $option = (string) $option;
        }
   

   Enabling filter here would also be a valid test fix, not sure if it is worth to check a third file.

2. +++ b/core/modules/contact/contact.info.yml
   @@ -5,3 +5,5 @@ package: Core
    version: VERSION
    core: 8.x
    configure: contact.category_list
   +dependencies:
   +  - text
   

   Does it really? Weren't those just test fails because they tried to add text fields to contact forms? If possible, I'd prefer to add the dependency to the tests, not contact.module.

   Also, based on those noticed, I'm guessing the field_ui is not handling the now possible case that there are no field types properly.

3. +++ b/core/modules/field/field.module
   @@ -87,7 +87,7 @@ function field_help($path, $arg) {
          $output .= '<dl>';
          $output .= '<dt>' . t('Enabling field types') . '</dt>';
   -      $output .= '<dd>' . t('The Field module provides the infrastructure for fields and field attachment; the field types and input widgets themselves are provided by additional modules. Some of the modules are required; the optional modules can be enabled from the <a href="@modules">Modules administration page</a>. Drupal core includes the following field type modules: Number (required), Text (required), List (required), Taxonomy (optional), Image (optional), and File (optional); the required Options module provides input widgets for other field modules. Additional fields and widgets may be provided by contributed modules, which you can find in the <a href="@contrib">contributed module section of Drupal.org</a>. Currently enabled field and input widget modules:', array('@modules' => url('admin/modules'), '@contrib' => 'http://drupal.org/project/modules', '@options' => url('admin/help/options')));
   +      $output .= '<dd>' . t('The Field module provides the infrastructure for fields and field attachment; the field types and input widgets themselves are provided by additional modules. The modules can be enabled from the <a href="@modules">Modules administration page</a>. Drupal core includes the following field type modules: Number, Text, Taxonomy, Image, File, Email, Link, Telephone, and Options. Additional fields and widgets may be provided by contributed modules, which you can find in the <a href="@contrib">contributed module section of Drupal.org</a>.', array('@modules' => url('admin/modules'), '@contrib' => 'http://drupal.org/project/modules', '@options' => url('admin/help/options')));
    
          // Make a list of all widget and field modules currently enabled, ordered
   

   When you are changing the text anyway, add Entity Reference? Instead of opening another issue...

Yeah, I had a similar problem with the node issue where that list wasn't the same locally and on the testbot. It does seem to be stable on the same environment though. The test doesn't seem to be failing on 5.4/5.5 on testbot. But it is scary, maybe we should switch to a different module with a smaller and more specific dependency tree? We've extended this line multiple times now, always adding more to the list as we change dependencies and make more modules optional...

Not in this issue....

probably related, suppose needs separate issue but CommentDefaultFormatter::viewElements() uses $this->settings['pager_id'] so defaults are skipped, this should be $this->getSetting('pager_id')

The fast/physical test bots have a fairly reliable text execution time now unlike the virtual ones, so that might actually mean something yes. Some sort of dependency tree/count of tests that don't rely on text/node and are now avoiding those 3 modules would be interesting, not sure how many of those we really have. Might write something :)

Patch looks great and is quite small now, that's great.

A follow-up to investigate the warnings thrown in field_ui if there are no field_types available would be great but this is RTBC.

Note that this issue doesn't need a new change record, we only need to update the existing one linked in #13, which is trivial and we don't need to prepare anything for that, so we're good.

Committed/pushed to 8.x, thanks!

Seems like we ought to be close to Field module not being required now?

Updated https://drupal.org/node/1397856, now mentions all modules that were made optional so far.

Looks like the change record is taken care of. Thanks!