#2063403: Fatal when editing a nonexistent image effect added the UnknownPluginException for use in the image module. But not a lot of thought was put into the naming.

It's not that we found a plugin and don't know what to do with it (unknown) it's that we couldn't find one (not found).

In other places, we have RouteNotFoundException, FileNotFoundException, DatabaseNotFoundException... So let's follow that instead.

CommentFileSizeAuthor
#3 interdiff.txt989 bytestim.plunkett
#3 plugin-exception-2189985-3.patch7.54 KBtim.plunkett
plugin-not-found-exception.patch7.25 KBtim.plunkett

Comments

msonnabaum’s picture

msonnabaum commented
Status: Needs review » Reviewed & tested by the community

Looks great. Much clearer. RTBC-ing assuming tests come back ok.

eclipsegc’s picture

eclipsegc commented
Status: Reviewed & tested by the community » Needs work 
$message = String::format("Plugin ID '@instance' was not found.", array('@instance' => $plugin_id));

Can we change @instance too?

Otherwise this seems super logical to me.

Eclipse

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs work » Needs review
StatusFileSize
new plugin-exception-2189985-3.patch7.54 KB
new interdiff.txt989 bytes

I see your nitpick and I raise you a decoupling.

eclipsegc’s picture

eclipsegc commented
Status: Needs review » Reviewed & tested by the community

RE-RTBC assuming tests pass.

Eclipse

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

That does indeed make more sense.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.