[D7] Yandex.Share with Counters

Hi @paulanders. Thanks for your application.

I just wanted to add links to demos for other reviewers:
The block is located in the header of http://hookany.com/
The field is displayed on the node page http://hookany.com/jobs/85759555-3bb1-4bfb-9525-1ffefad7621d

There are some errors reported by automated review tools, did you already check them? See http://pareview.sh/pareview/httpgitdrupalorgsandboxpaulanders2030639git

We are currently quite busy with all the project applications and we prefer projects with a review bonus. Please help reviewing and put yourself on the high priority list, then we will take a look at your project right away :-)

Also, you should get your friends, colleagues or other community members involved to review this application. Let them go through the review checklist and post a comment that sets this issue to "needs work" (they found some problems with the project) or "reviewed & tested by the community" (they found no major flaws).

I'm a robot and this is an automated message from Project Applications Scraper.

I've just reviewed the module. Here are the results:

1. Bug found: #2193879: Size switcher doesn't work
2. Please add the module name at the top of README.txt
3. Also, you might want to split readme by sections, e.g. https://drupal.org/node/2181737
4. Please fix coding standards and follow recommendations listed here: http://pareview.sh/pareview/httpgitdrupalorgsandboxpaulanders2030639git

The code looks good overall and the module works fine. Also, It is used on several live projects.
So please fix issues listed above and we'll go to RTBC.

Good job, thank you!

I'm changing the status to RTBC.

That's what I was looking for! Good module! Thank you!

I use this module, it's useful.

Thanks for your module!

I can confirm RTBC. Thanks for sharing!

Hey guys.
Any updates by this issue? It was published more than month ago.
What's wrong with it?

Thanks,
Konstantin

Hello all,

I don't see any reason why this module can't be the part of already existing Yandex.Share module - https://www.drupal.org/project/yashare - it already has 600+ installations.
If the author doesn't have time to maintain it - he can add co-maintainers. He already did so for the Adminer module he authored - I just asked him to add me as co-maintainer. If he doesn't want to add co-maintainers (I doubt it is so) and is not active in the issue queue or has no plans to maintain the module - then there is a process to handle it - https://www.drupal.org/node/251466

"Collaboration rather than competition" - https://www.drupal.org/contribute/development#collaboration

I can help with contacting the author and asking him to add maintainers.

Thoughts?

Thanks
AndyB

I don't see any reason why this module can't be the part of already existing Yandex.Share module - https://www.drupal.org/project/yashare - it already has 600+ installations.

It is not supported nor developed.

From the issue description:

I contacted with maintainer of Yandex.Share module and he said that he had not enought time to maintain this module. Also considering less demand features of old buttons now, i decided to make separate project.

he can add co-maintainers

Would you like to co-maintain?

"Collaboration rather than competition" - https://www.drupal.org/contribute/development#collaboration

There is not a competition here, there are just bureaucracy and at least 50% unsupported modules on drupal.org.
Why should we wait until their authors have time. Why should we spend time to co-maintain if we don't need that functionality at all.

I can help with contacting the author and asking him to add maintainers.

We can't forbid you contacting to the author by any needs.

Several well-know people in the community confirmed RTBC. Doesn't it sound persuasively?

I contacted with maintainer of Yandex.Share module and he said that he had not enought time to maintain this module. Also considering less demand features of old buttons now, i decided to make separate project.

Yes, I read that. Yes, it happens. But we didn't develop another Views module when it happened with the Views module, right?
The Drupal community have developed rules (guidelines) to follow, and we should follow them (and there should be a process to change these rules if you want, right?). At least this is my understanding. If this is not correct - please correct me.

And in this case guideline says that we should continue with the already created project - become a co-maintainer and add new features to the existing module.

Would you like to co-maintain?

Yes, I would love to help if needed.

Why should we wait until their authors have time. Why should we spend time to co-maintain if we don't need that functionality at all.

Cause we are community and we do so for the people who are already using the modules that become obsolete/not maintained.

Several well-know people in the community confirmed RTBC. Doesn't it sound persuasively?

This is not a "democracy"; we can't allow to vote for a project (at least for now; but sounds like a suggestion) - we have guidelines and we should follow them.

There is a project that already integrates the same API from the same provider for the same goal - isn't it clear?

You have a very idealistic opinion regarding community rules that are ten years old.
I have expressed my point well and am not going to argue anymore just to save my time (it's not the first endless dispute with you).
I would let the issue owner decide what to do next.

Cheers,
Konstantin

I agree that we should try to get this into the existing project. Please open an issue in the yashare issue queue to discuss what you need. You should also get in contact with the maintainer(s) to offer your help to move the project forward (for example by opening a 7.x-2.x branch). If you cannot reach the maintainer(s) please follow the abandoned project process.

If that fails for whatever reason please get back to us and set this back to "needs review".

I have contacted the maintainer yesterday and he agreed to add me as a co-maintainter.

I have opened the 7.x-2.x branch of the https://www.drupal.org/project/yashare module and added buttons with counters support there. I have also opened 2 issues to work on in the 7.x-2.x branch - sortable table of services + integration with Variable module.
If you have any further questions - please contact me.

So this issue is closed (duplicate).

Thanks
AndyB

You've just created a duplicate for the original project https://github.com/paulanders/yashare_counters
Good luck with the maintaining!