Updated: Comment #0

Problem/Motivation

The 'Delete' operation in the list of image styles is no longer available, after commit of #2167641: EntityInterface::uri() should use route name and not path. Also, the 'Delete' link in the image style edit form is not working (in fact it was not working before either).

Proposed resolution

Add the 'delete-form' link in the annotation of ImageStyle. Also, use the opportunity to convert the 'cancel' link in effect edit to use route_name and route_parameter instead of href.

Remaining tasks

Review patch

User interface changes

API changes

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

mondrake’s picture

Status: Active » Needs review
FileSize
1.67 KB

Patch.

tim.plunkett’s picture

Issue tags: +Needs tests

Nice catch, but we should add a test.

mondrake’s picture

Test added. Test_only patch should fail, the other is combining patch and test and should be OK. Test_only patch equals the interdiff.

The last submitted patch, 3: image_style_delete-2187335-3-test_only.patch, failed testing.

The last submitted patch, 3: image_style_delete-2187335-3-test_only.patch, failed testing.

mondrake’s picture

Issue tags: -Needs tests
tim.plunkett’s picture

Status: Needs review » Reviewed & tested by the community

@mondrake++

catch’s picture

Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.