It's noted in 3.8 there's now a hard coded extra space preceding the 'in the !group group' token. This causes a translation problem where such an extra space is not desired.

Formerly:

function commons_groups_related_groups_text($related_groups) {
  // In 1 group: "in the x group"
  if (count($related_groups) == 1) {
    return t(' in the !group group', array('!group' => l($related_groups[0]->title, 'node/' . $related_groups[0]->nid)));
  }

Currently:

function commons_groups_related_groups_text($related_groups) {
  // In 1 group: "in the x group"
  if (count($related_groups) == 1) {
    return ' ' . t('in the !group group', array('!group' => l($related_groups[0]->title, 'node/' . $related_groups[0]->nid)));
  }
CommentFileSizeAuthor
#2 revert-in-the-group-token-preceding-space-2187147-2.patch2.24 KBdaniel.c

Comments

ezra-g’s picture

ezra-g commented

Thanks for the report here. Are you able to provide this change as a patch?

daniel.c’s picture

daniel.c commented
Status: Active » Needs review
StatusFileSize
new revert-in-the-group-token-preceding-space-2187147-2.patch2.24 KB

I'm mainly a site builder but glad to provide a simple patch which reverts the function back to its pre-3.8 state.

  • Commit a0a9ba7 on 7.x-3.x by japerry: 
    Issue #2187147 by daniel.c: Remove preceding space from translation in...
japerry’s picture

japerry
Location KOMK
commented
Version: 7.x-3.8 » 7.x-3.x-dev
Status: Needs review » Fixed

Fixed! Silly code format cleaner decided that putting a space in front of the translation was a good idea, but I don't see anywhere that its acceptable to do that.

Reverted back before the space. Thanks for the report!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.