There are a few requests to use linkit on fields as well as within a wysiwyg editor. It appears that the 3.x version of linkit is offering this capability but panopoly is on linkit 7.x-2.6.
Unfortunately linkit does not (currently) provide an upgrade path from 2.x -> 3.x.
Related Issues:
#2173535: Use linkit on Spotlight
#2013965: ability to link images placed with image widget
| Comment | File | Size | Author |
|---|---|---|---|
| #15 | panopoly_test-linkit_3_upgrade-2186541-15.patch | 1.64 KB | dsnopek |
| #13 | panopoly_wysiwyg-linkit_3_upgrade-2186541-13.patch | 4.36 KB | dsnopek |
Comments
Comment #1
ultimikeHere's another bug in LinkIt 7.x-2.x that occurs in Panopoly: https://drupal.org/node/2202625
Updating to LinkIt 7.x-3.x would solve this problem.
-mike
Comment #2
dansyv commentedAny work done on this? If not, does anyone know if there would be a problem if i upgrade the Linkit module in my Panopoly site?
As far as i can see, the 7.x-3.x have support for linking to url aliases (path/to/node) instead of node id (node/23). Or is there any other way to get this without upgrading?
Comment #3
caschbre commentedYou "should" be able to upgrade it on your own without breaking the rest of the site. I tested that a while back. The issue is that there is no upgrade path from 2.x -> 3.x which is holding us up in panopoly.
Definitely make a backup first! :)
Comment #4
boyan.borisov commentedComment #5
caschbre commentedFollowing the steps outlined in #2091789: Upgrade path 2.x to 3.0, here is a patch to upgrade linkit to 3.1.
Comment #6
dsnopekWow, thanks! :-) I'm running this through the tests (including the upgrade tests) on Travis-CI:
https://travis-ci.org/dsnopek/panopoly/builds/29880892
The tests themselves will likely need some updates to work with the new Linkit, but we'll at least see if the upgrade works from several versions of Panopoly.
Comment #7
dsnopekAh, sorry, the last Travis-CI attempt didn't include the upgrade tests. This one should:
https://travis-ci.org/dsnopek/panopoly/builds/29883050
Anyway, you can see that the tests will definitely need an update as well:
https://travis-ci.org/dsnopek/panopoly/builds/29880892#L814
Comment #8
dsnopekOk, the upgrade functions seem to have run fine! I'll do some manual testing with this later when I find some time.
Comment #9
caschbre commentedI'd be happy to help update the behat tests... but I may need some help / direction on those.
Comment #10
caschbre commentedAssigning so I remember to do this.
Comment #11
caschbre commentedAttached is an updated wysiwyg patch and test.
Comment #12
dsnopekAwesome, thanks for all your work on this! I've started another Travis-CI build with these patches:
https://travis-ci.org/dsnopek/panopoly/builds/34096798
This will still need some manual testing, though.
Comment #13
dsnopekHere's an updated version of this patch which does 2 things:
Comment #14
dsnopekRunning through Travis-CI one last time:
https://travis-ci.org/dsnopek/panopoly/builds/37493377
But everything looked great in my manual testing! So, this is about ready to be committed. :-)
Comment #15
dsnopekTravis-CI tests failed because apparently the button title changed from 'Linkit' to 'Link to content' in linkit 3.2. Here is a new patch to the tests which is adjusted for that!
Comment #16
dsnopekAnd here's a new Travis-CI build for the new test patch:
https://travis-ci.org/dsnopek/panopoly/builds/37497139
Comment #18
dsnopekTravis-CI tests haven't finished but they've gotten past the Linkit tests even on some upgrade tests (which is the what I wanted to check), so I'm satistfied. Committed!
Comment #19
populist commentedAs a note, if you have made significant customizations to the LinkIt profile and are experiencing either WSOD issues on node pages or JS errors in the WYSIWYG you may need to do a revert at /admin/config/content/linkit.