There are a few requests to use linkit on fields as well as within a wysiwyg editor. It appears that the 3.x version of linkit is offering this capability but panopoly is on linkit 7.x-2.6.

Unfortunately linkit does not (currently) provide an upgrade path from 2.x -> 3.x.

Related Issues:
#2173535: Use linkit on Spotlight
#2013965: ability to link images placed with image widget

Comments

ultimike’s picture

Here's another bug in LinkIt 7.x-2.x that occurs in Panopoly: https://drupal.org/node/2202625

Updating to LinkIt 7.x-3.x would solve this problem.

-mike

dansyv’s picture

Any work done on this? If not, does anyone know if there would be a problem if i upgrade the Linkit module in my Panopoly site?

As far as i can see, the 7.x-3.x have support for linking to url aliases (path/to/node) instead of node id (node/23). Or is there any other way to get this without upgrading?

caschbre’s picture

You "should" be able to upgrade it on your own without breaking the rest of the site. I tested that a while back. The issue is that there is no upgrade path from 2.x -> 3.x which is holding us up in panopoly.

Definitely make a backup first! :)

boyan.borisov’s picture

caschbre’s picture

Status: Active » Needs review
StatusFileSize
new4.36 KB

Following the steps outlined in #2091789: Upgrade path 2.x to 3.0, here is a patch to upgrade linkit to 3.1.

dsnopek’s picture

Wow, thanks! :-) I'm running this through the tests (including the upgrade tests) on Travis-CI:

https://travis-ci.org/dsnopek/panopoly/builds/29880892

The tests themselves will likely need some updates to work with the new Linkit, but we'll at least see if the upgrade works from several versions of Panopoly.

dsnopek’s picture

Status: Needs review » Needs work

Ah, sorry, the last Travis-CI attempt didn't include the upgrade tests. This one should:

https://travis-ci.org/dsnopek/panopoly/builds/29883050

Anyway, you can see that the tests will definitely need an update as well:

https://travis-ci.org/dsnopek/panopoly/builds/29880892#L814

Then the "edit-linkit-path" field should contain "/node/"
  The field "edit-linkit-path" value is "node/11", but "/node/" expected.
dsnopek’s picture

Component: Miscellaneous » WYSIWYG

Ok, the upgrade functions seem to have run fine! I'll do some manual testing with this later when I find some time.

caschbre’s picture

I'd be happy to help update the behat tests... but I may need some help / direction on those.

caschbre’s picture

Assigned: Unassigned » caschbre

Assigning so I remember to do this.

caschbre’s picture

Status: Needs work » Needs review
StatusFileSize
new4.36 KB
new1.2 KB

Attached is an updated wysiwyg patch and test.

dsnopek’s picture

Awesome, thanks for all your work on this! I've started another Travis-CI build with these patches:

https://travis-ci.org/dsnopek/panopoly/builds/34096798

This will still need some manual testing, though.

dsnopek’s picture

StatusFileSize
new4.36 KB

Here's an updated version of this patch which does 2 things:

dsnopek’s picture

Running through Travis-CI one last time:

https://travis-ci.org/dsnopek/panopoly/builds/37493377

But everything looked great in my manual testing! So, this is about ready to be committed. :-)

dsnopek’s picture

StatusFileSize
new1.64 KB

Travis-CI tests failed because apparently the button title changed from 'Linkit' to 'Link to content' in linkit 3.2. Here is a new patch to the tests which is adjusted for that!

dsnopek’s picture

And here's a new Travis-CI build for the new test patch:

https://travis-ci.org/dsnopek/panopoly/builds/37497139

  • dsnopek committed f22c528 on 7.x-1.x
    Update Panopoly WYSIWYG and Test for #2186541 by caschbre, dsnopek:...
dsnopek’s picture

Status: Needs review » Fixed

Travis-CI tests haven't finished but they've gotten past the Linkit tests even on some upgrade tests (which is the what I wanted to check), so I'm satistfied. Committed!

populist’s picture

As a note, if you have made significant customizations to the LinkIt profile and are experiencing either WSOD issues on node pages or JS errors in the WYSIWYG you may need to do a revert at /admin/config/content/linkit.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.