Since the introduction of EntityFormDisplays, field instances hold no 'widget' data in D8.

There were leftover 'widget' entries in a couple test field.instance.*.yml files, so #2167623: Add test for all default configuration to ensure schema exists and is correct added a 'widget' schema entry for field.instance.* for compliance.

Instead, the existing 'widget' entries should be removed altogether.

Same for 'active' in field.field.*.yml.

CommentFileSizeAuthor
#5 interdiff.txt428 bytesyched
#5 field_instance_schema_widget-2185689-5.patch4.39 KByched
#1 field_instance_schema_widget-2185689-1.patch4.17 KByched

Comments

yched’s picture

yched commented
Status: Active » Needs review
StatusFileSize
new field_instance_schema_widget-2185689-1.patch4.17 KB
yched’s picture

yched commented
Issue summary: View changes
vijaycs85’s picture

vijaycs85
Location London, UK
commented

Looks good to me. +1 to RTBC.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community
yched’s picture

yched commented
Title: Remove 'widget' in field instance schemas » Remove stale entries in field / field instance schemas
Issue summary: View changes
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new field_instance_schema_widget-2185689-5.patch4.39 KB
new interdiff.txt428 bytes

Sorry - actually, same for the 'active' property that got added in field.field.* schemas - doesn't exist anymore either.
That one isn't used anywhere in actual field.field.*.yml files within current core though.

swentel’s picture

swentel commented
Status: Needs review » Reviewed & tested by the community
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

NIce cleanup. Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.