Problem

  • When installing Drupal in a browser in a different language than English, then the browser language is preselected.
  • To install in English, one has to manually find the "English" option in the select dropdown.

Goal

  • Simply allow to click the "English" in the description text:

CommentFileSizeAuthor
#7 2185583-install-english-7.patch1.03 KBlongwave
#1 drupal-install-allow-select-english-2185583-1.patch1.04 KBinternetdevels
install-english.png13.31 KBsun

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-install-allow-select-english-2185583-1.patch1.04 KB

Patch added.

Status: Needs review » Needs work

The last submitted patch, 1: drupal-install-allow-select-english-2185583-1.patch, failed testing.

tibezh’s picture

tibezh commented
Status: Needs work » Needs review

1: drupal-install-allow-select-english-2185583-1.patch queued for re-testing.

nod_’s picture

nod_
Primary language French
Location Lille
commented

Ohh I like that no-js solution :)

nod_’s picture

nod_
Primary language French
Location Lille
commented
Status: Needs review » Reviewed & tested by the community

That works for me, @sun are you set on a JS solution or is that good enough?

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs review

Oh, hah, a simple link that contains the langcode query parameter is creative :-)

I hope that no installation profile ever wants to alter/enhance this form — but right now there are no such use-cases, and if they arise, we can still change this implementation at any time later on.

The only remark I have is to remove the wrapping EM tag, because the link is actually a regular link now.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
StatusFileSize
new 2185583-install-english-7.patch1.03 KB

Clever solution!

I removed the <em> tag and also removed one unnecessary space.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Needs review » Reviewed & tested by the community

Thanks! :)

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
commented
Status: Reviewed & tested by the community » Fixed

Committed 22fa67d and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.