Updated: Comment #N

Problem/Motivation

The code in content_translation_menu_link_defaults_alter() refers to a variable named $items, that should be $links.

Proposed resolution

Rename the variable to $links.

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#4 increment.txt935 bytespwolanin
#4 2184707-3.patch2.7 KBpwolanin
#2 2184707-2.patch2.69 KBpwolanin

Comments

pwolanin’s picture

pwolanin commented
Assigned: Unassigned » pwolanin
Issue tags: -Novice +WSCCI

The machine names might be wrong too. Not really novice. I think I fixed a simular break in config_translation.

Rolling a patch

pwolanin’s picture

pwolanin commented
Status: Active » Needs review
StatusFileSize
new 2184707-2.patch2.69 KB

Fix plus test coverage.

dawehner’s picture

dawehner
Primary language German
commented
Status: Needs review » Reviewed & tested by the community

It is great to get some testcoverage for that code now. You could argue that breaking the code was good :)

pwolanin’s picture

pwolanin commented
StatusFileSize
new 2184707-3.patch2.7 KB
new increment.txt935 bytes

Better code comment.

pwolanin’s picture

pwolanin commented

4: 2184707-3.patch queued for re-testing.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.