The only call to LinkGenerator::getActive() was in theme_links(), and that was removed in #1979468: ".active" from linkGenerator(), l() and theme_links() forces an upper limit of per-page caching for all content containing links.
The tests were never updated to stop calling setRequest() manually, but it has no effect, because the request is never used internally.

We can then also remove the dependency on language_manager, since it is never used.

CommentFileSizeAuthor
#1 link-generator-2184649-1.patch10.06 KBtim.plunkett

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new link-generator-2184649-1.patch10.06 KB
dawehner’s picture

dawehner
Primary language German
commented

I am confused, didn't the other issue at least wanted to add an active class for anonymous users?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Assigned: Unassigned » wim leers

Well in the patch in #162 in that issue, this was still used in PHP.
But by #173, it had been removed.

#172 said:

After an additional discussion with catch about this, we concluded that we can only solve this by using #post_render_cache for anonymous users. That still means that when the page cache is used, no #post_render_cache callbacks need to happen!

Wim, can you enlighten us?

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Assigned: wim leers » Unassigned
Status: Needs review » Reviewed & tested by the community
Related issues: +#1979468: ".active" from linkGenerator(), l() and theme_links() forces an upper limit of per-page caching for all content containing links

#2: that does happen, but not there, it's done in a #post_render_cache callback. Rationale + details: see #1979468.

My apologies for missing this in #1979468, all of the changes made here should indeed have been done there. Patch is green, and all changes look sane. So: RTBC :)

Thanks, Tim!

wim leers’s picture

wim leers
Location Ghent 🇧🇪🇪🇺
commented
Issue tags: +quickfix
catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.