Integration with the Variable module enables modules, like Contextual Variables and Configuration builder modules, to expand the functionality of this module, allowing for things like variable switching based on environment or customized configuration pages and more.

CommentFileSizeAuthor
#6 Variables.png54.47 KBjoelpittet
#1 add_variable_module_integration-2183195-1.patch2.87 KBrealityloop

Comments

realityloop’s picture

realityloop commented
StatusFileSize
new add_variable_module_integration-2183195-1.patch2.87 KB

Patch attached

thedavidmeister’s picture

thedavidmeister commented
Status: Active » Needs review
deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

bump

greggles’s picture

greggles
he/him
Primary language English
Location Denver, Colorado, USA
commented

Rather than bumping could you review the code?

deciphered’s picture

deciphered
Primary language English
Location Ballarat, Victoria, Australia
commented

Not in an unbiased way, as I oversaw the code and did an internal review prior to the patch being submitted due to working at Realityloop.

While I could mark it as RTBC I feel that would be an abuse of my position.

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
Assigned: realityloop » Unassigned
Issue summary: View changes
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Variables.png54.47 KB

Reviewed code, double checked to ensure there was no extra variables or missing variables.

Grouping them is a nice touch.

markdorison’s picture

markdorison
he/him
commented

RTBC.

BarisW credited axel.rutz.

BarisW’s picture

BarisW commented
Status: Reviewed & tested by the community » Fixed

Committed, so fixed.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.