Problem/Motivation

LocaleUninstallTest is unnecessary since language and locale converted to CMI and the Language module and Core have different language managers. Module uninstall cleans up both the CMI files and rebuilds the container making the problems these tests trying to expose now a non issue.

This critical since it is removing a variable_set and hence blocking #2167109: Remove Variable subsystem

Proposed resolution

Remove LocaleUninstallTest and LocaleUninstallFrenchTest.

Remaining tasks

Review

User interface changes

None

API changes

None

Files: 
CommentFileSizeAuthor
d8.remove-locale-uninstall-tests.patch7.63 KBalexpott
PASSED: [[SimpleTest]]: [MySQL] 63,259 pass(es). View

Comments

Gábor Hojtsy’s picture

Status: Needs review » Reviewed & tested by the community
Issue tags: +language-ui, +sprint

I was not entirely happy with this proposal and unsure if other tests cover this and if we are making too many assumptions if we remove this, but @alexpott convinced me in IRC :) Looks good.

alexpott’s picture

Drupal\system\Tests\Module\InstallUninstallTest tests the CMI files are removed and the expected actions occur during an uninstall.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Seems a bit odd to be removing test coverage, but it sounds like these cases are (indirectly) covered elsewhere.

Committed and pushed to 8.x. YEAH! Are we finally through the last of the blockers to ripping out the variable system?!

Gábor Hojtsy’s picture

Issue tags: -sprint

Removing from sprint.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.