LocaleUninstallTest is unnecessary since language and locale converted to CMI and the Language module and Core have different language managers. Module uninstall cleans up both the CMI files and rebuilds the container making the problems these tests trying to expose now a non issue.
This critical since it is removing a variable_set and hence blocking #2167109: Remove Variable subsystem
Remove LocaleUninstallTest and LocaleUninstallFrenchTest.
Review
None
None
| Comment | File | Size | Author |
|---|---|---|---|
| d8.remove-locale-uninstall-tests.patch | 7.63 KB | alexpott |
Comments
Comment #1
gábor hojtsyI was not entirely happy with this proposal and unsure if other tests cover this and if we are making too many assumptions if we remove this, but @alexpott convinced me in IRC :) Looks good.
Comment #2
alexpottDrupal\system\Tests\Module\InstallUninstallTesttests the CMI files are removed and the expected actions occur during an uninstall.Comment #3
webchickSeems a bit odd to be removing test coverage, but it sounds like these cases are (indirectly) covered elsewhere.
Committed and pushed to 8.x. YEAH! Are we finally through the last of the blockers to ripping out the variable system?!
Comment #4
gábor hojtsyRemoving from sprint.