One of the remaining legitimate usages of the deprecated \Drupal::getContainer() method is to call ContainerInterface::has().
Let's provide a method for that on \Drupal, as suggested in #1376122-38: Stream wrappers of parent site are leaking into all tests

CommentFileSizeAuthor
container-has.patch5.86 KBtim.plunkett
#2 container-has-2182439-2.patch5.91 KBtim.plunkett

Comments

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented

I think since we have \Drupal::service() maybe \Drupal::hasService() would be more consistent. Note that we also have non-container stuff on \Drupal, i.e. \Drupal::VERSION and that's probably going to become more.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review
StatusFileSize
new container-has-2182439-2.patch5.91 KB

Good idea!

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Title: Provide a \Drupal::has() method » Provide a \Drupal::hasService() method
jibran’s picture

jibran
he/him
Primary language Urdu
Location Toronto, Canada
commented
Status: Needs review » Reviewed & tested by the community

\Issue::hasPatch() nice clean up so RTBC.

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Status: Reviewed & tested by the community » Needs review
Related issues: +#2084521: Improve error handling of \Drupal class

This duplicates #2084521: Improve error handling of \Drupal class to a good extent...

sun’s picture

sun
Primary language German
Location Karlsruhe
commented
Related issues: +#2160655: Improve error handling of \Drupal class

err, actually #2160655: Improve error handling of \Drupal class

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented

It doesn't duplicate a single line of that patch. It does conflict with it, sure.

Status: Needs review » Needs work

The last submitted patch, 2: container-has-2182439-2.patch, failed testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs work » Needs review

2: container-has-2182439-2.patch queued for re-testing.

tstoeckler’s picture

tstoeckler
he/him
Primary language German
Location Essen, Germany
commented
Status: Needs review » Reviewed & tested by the community

Back to RTBC.

catch’s picture

catch
he/him
Primary language English
commented
Title: Provide a \Drupal::hasService() method » Change notice: Provide a \Drupal::hasService() method
Status: Reviewed & tested by the community » Active
Issue tags: +Needs change record

Committed/pushed to 8.x, thanks!

Could use a change notice/update.

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Missing change record
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Active » Needs review

https://drupal.org/node/2191411

xjm’s picture

xjm
she/her
Primary language English
commented
Title: Change notice: Provide a \Drupal::hasService() method » Provide a \Drupal::hasService() method
Status: Needs review » Fixed
Issue tags: -Needs change record, -Missing change record

I keep editing the issue out of habit. :)

Change record looks good; published. I searched for "getContainer" in the existing change records and it doesn't look like there's anything else to update.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.