taxonomy_vocabulary_delete() does more than just delete a vocab

Well... that seems like necessary housekeeping that would be implied if you delete a vocabulary, but sure we could document it.

Good point. Patch?

hi,
i suggest following patch.

Thanks

Looks like the patch documents what it should... However, there's a spelling error in the first line: "vocabulay". Whoops! :)

Also, looking at the code for this function, it appears that it first updates all Taxonomy fields so that they don't reference the deleted vocabulary, and then completely removes fields that have no referenced vocabularies left.

I'm also circling back to wondering how essential it is to document this anyway. The same code is executed in Drupal 8 on Vocabulary::preDelete() [that does the term deletes] and Vocabulary::postDelete() [that takes care of the fields]. If it needs to be documented in 7, then it probably needs to be documented in 8; whether it really needs to be documented at all is a question, but moving to 8.x for action because we have a policy of fixing bugs in 8 first and then 7.

I'd really be inclined to mark this "won't fix" or "works as designed" though, as I suggested in #1.

Hi,
here are suggested patches for D8 and D7
Thanks

oups !
i forget to mention do-not-test for the D7 patch

Hm. OK, let's after all just do this for 7, if we're doing it at all.The argument about needing to do this only applies to the 7.x function; the 8.x methods are not really meant to be called directly, and if we make the 8.x patch that is suggested, we will lose the generic preDelete() and postDelete() documentation that we were inheriting, which is not a great thing really.

So on the 7.x patch...

+ * This will at first update all Taxonomy fields so that they don't reference
+ * the deleted vocabulary and then delete all the terms of the vocabulary and
+ * all Taxonomy module fields that use only this vocabulary.

- In the first line, "at first" should just be "first"... but....
- Can we make it two sentences, one about deleting the terms, and the other about the fields? The order actually doesn't matter, so instead of "first" and "then", we can just use "also".
- I think the end phrase about deleting "all Taxonomy module fields that use only this vocabulary" doesn't make sense in the context of having already updated the fields -- at that point, no taxonomy fields use the vocabulary, so what is being deleted is just the ones that are now empty of references. So maybe it would be clearer to say:

... update all Taxonomy fields so that they don't reference the deleted vocabulary, and then delete fields that have no remaining vocabulary references"

?

here it is :)
Thanks

Please wrap the documentation so it all goes into one paragraph, or if you think it should be two separate paragraphs, put them on separate lines. Thanks!

We also need the documentation to state that all terms in the vocabulary are deleted.

Hi,
Here it is
Thanks for the review

Thanks! That looks good to me.

Thanks again! Committed to 7.x.