In the root README.txt, bulleted lists in the Installation Profiles section does not indent properly compared to the other bullets. Generally speaking, the standard is to indent bullets with one space before an asterisk.

CommentFileSizeAuthor
#11 bullet_indents_readme-2181809-11.patch990 bytesdavidneedham
#1 bullet_indents_readme-2181809-1.patch988 bytesdavidneedham

Comments

davidneedham’s picture

davidneedham
he/him
commented
StatusFileSize
new bullet_indents_readme-2181809-1.patch988 bytes

Here's a patch that updates that particular section.

davidneedham’s picture

davidneedham
he/him
commented
Status: Active » Needs review
les lim’s picture

les lim
he/they
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Seems legit.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Component: other » documentation
Priority: Normal » Minor

Triaging the normal queue.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Postponed (maintainer needs more info)

Um... Really? Our standards for list indentation generally say that if we use - in lists, it aligns with the text above. What makes you think this should be indented?

davidneedham’s picture

davidneedham
he/him
commented

Because we're looking at asterisks (rather than -), which are intended everywhere else in README.txt files for Drupal 8 and Drupal 7 (though this bug does exist Drupal 7 as well).

We could replace the *'s with -'s and forego the spacing, but I'm not aware of a significant difference.

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented

@jhodgdon: The other bullets in that file are all indented by one space, the installation profiles does not follow this for whatever reason. So, we should either fix the installation profiles section, or fix all the other sections instead.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

Fair enough. Thanks!

longwave’s picture

longwave
he/him
Primary language English
Location UK
commented
Issue tags: +Needs backport to D7
jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Version: 8.x-dev » 7.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks again everyone! Committed to 8.x.

Patch doesn't apply to 7, so needs a reroll.

davidneedham’s picture

davidneedham
he/him
commented
Status: Patch (to be ported) » Needs review
StatusFileSize
new bullet_indents_readme-2181809-11.patch990 bytes

Rerolled for 7

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

Thank you!

jhodgdon’s picture

jhodgdon
she/her
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Thanks again - committed to 7.x.

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.