Problem/Motivation

After page load, active 'toolbar-tray' link requires double click to collapse/close expanded menu links.

Proposed resolution

To be determined.

Remaining tasks

To be determined.

User interface changes

No interface changes.

Comments

draganeror’s picture

Issue summary: View changes
draganeror’s picture

Issue tags: +#SprintWeekend2014
maggo’s picture

Status: Active » Needs review
StatusFileSize
new1002 bytes

Here we go, tab IDs and DOM Elements were mixed up in the click handler

maggo’s picture

Issue tags: +D8MA
nod_’s picture

Yay! thanks!

We use one var per line, could you reroll your patch to keep it consitant with the rest of the JS? thanks :)

nod_’s picture

Status: Needs review » Needs work
draganeror’s picture

Status: Needs work » Needs review
StatusFileSize
new1010 bytes

Variables are now set in separate lines.

draganeror’s picture

StatusFileSize
new1004 bytes

Removed white space.

nod_’s picture

Status: Needs review » Needs work

+ var clickedTab = document.getElementById(event.target.id);
+ var clickedTab = event.target;
same :)

The last submitted patch, 7: toolbar-toggle-button-2181525-7.patch, failed testing.

The last submitted patch, 3: 2181525-3-toolbar-toggle-button-fix.patch, failed testing.

maggo’s picture

Status: Needs work » Needs review
StatusFileSize
new976 bytes

d'oh! you're right

The last submitted patch, 8: toolbar-toggle-button-2181525-8.patch, failed testing.

The last submitted patch, 8: toolbar-toggle-button-2181525-8.patch, failed testing.

draganeror’s picture

Status: Needs review » Reviewed & tested by the community

Tested #12, it works nice.

webflo’s picture

Issue tags: -#SprintWeekend2014 +SprintWeekend2014
nod_’s picture

rtbc+1

clemens.tolboom’s picture

Please update the summary to reflect something in line with #2165017: toolbar needs click twice to close due to jQuery calling getPreventDefault() as I guess these issues are the same.

nod_’s picture

StatusFileSize
new942 bytes

This is a reroll because the indentation standard changed for JavaScript files. No need for commit credit because of this reroll.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.