Closed (fixed)
Project:
Drupal core
Version:
8.0.x-dev
Component:
javascript
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
25 Jan 2014 at 14:49 UTC
Updated:
29 Jul 2014 at 23:18 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
draganerorComment #2
draganerorComment #3
maggo commentedHere we go, tab IDs and DOM Elements were mixed up in the click handler
Comment #4
maggo commentedComment #5
nod_Yay! thanks!
We use one
varper line, could you reroll your patch to keep it consitant with the rest of the JS? thanks :)Comment #6
nod_Comment #7
draganerorVariables are now set in separate lines.
Comment #8
draganerorRemoved white space.
Comment #9
nod_+ var clickedTab = document.getElementById(event.target.id);+ var clickedTab = event.target;same :)
Comment #12
maggo commentedd'oh! you're right
Comment #15
draganerorTested #12, it works nice.
Comment #16
webflo commentedComment #17
nod_rtbc+1
Comment #18
clemens.tolboomPlease update the summary to reflect something in line with #2165017: toolbar needs click twice to close due to jQuery calling getPreventDefault() as I guess these issues are the same.
Comment #19
nod_This is a reroll because the indentation standard changed for JavaScript files. No need for commit credit because of this reroll.
Comment #20
webchickCommitted and pushed to 8.x. Thanks!