Hi,
I noticed a Error notice in Menu settings page.

What are the steps required to reproduce the bug? :

1) Install Drupal 8.0-alpha8+76-dev
2) Visit "admin/structure/menu/settings"

What behavior were you expecting? :

No warnings or error notices on this page.

What happened instead?

Getting error notice "Notice: Undefined index: main in Drupal\menu\MenuSettingsForm->buildForm() (line 54 of core\modules\menu\lib\Drupal\menu\MenuSettingsForm.php). "

CommentFileSizeAuthor
#2 MenuSettingsForm.php-2181469-comment1.patch1.37 KBkarthikkumarbodu

Comments

swentel’s picture

swentel commented
Version: 8.0-alpha8 » 8.x-dev
Status: Active » Closed (cannot reproduce)

I can't reproduce this with latest HEAD - that line doesn't even contain anything anymore that would trigger that error.

karthikkumarbodu’s picture

karthikkumarbodu commented
Status: Closed (cannot reproduce) » Needs review
StatusFileSize
new MenuSettingsForm.php-2181469-comment1.patch1.37 KB

Hey Swentel, I was able to report the above error notice in the previous Dev release. We can reproduce the error only when there are no menus in the "Menus" administration page, this is never going to happen as we get five menus by default after the installation. I am providing a simple patch to suppress the error in such conditions.

swentel’s picture

swentel commented

Mmm right, like that, good catch

jhedstrom’s picture

jhedstrom
Primary language English
Location Portland, OR
commented
Status: Needs review » Needs work
Issue tags: +Needs reroll

After #1869476: Convert global menus (primary links, secondary links) into blocks, this might no longer be an issue.

Vikas.Kumar’s picture

Vikas.Kumar commented
Status: Needs work » Closed (won't fix)

Hi there, i checked that this "core\modules\menu" does not exist at latest Drupal dev 8.0.x. So it should need to be close.