Remove caption filter's caption-specific alignment classes [#2180627]

Updated: Comment #0

Problem/Motivation

#2170085: Caption filter may not wrap images that are only aligned, not captioned fixed a major problem. But it kind of introduced a minor new one: we introduced generic alignment classes for non-textual content. That's fine, or great even.

The problem we subtly introduced, was that we didn't remove the caption alignment classes. So now we not only have align-(left|center|right), but we also still have caption-(left|center|right).

This is problematic when you take into account that the CKEditor widget that provides a great authoring UX for aligning/captioning images also has to know about these different classes: if the image is captioned, it must set caption-(left|center|right), if it's not captioned, it must set align-(left|center|right). That's unnecessary complexity. Therefor it complicates #2039163: Update CKEditor library to 4.4.

Proposed resolution

Get rid of the caption-(left|center|right) classes.

Remaining tasks

None.

User interface changes

None.

API changes

None.

Comment	File	Size	Author
#7	remove_caption_alignment_classes-2180627-7.patch	6.63 KB	jessebeach
#7	reject-bit.txt	2.02 KB	jessebeach
#3	interdiff.txt	575 bytes	jessebeach
#2	interdiff.txt	5.95 KB	jessebeach
#2	remove_caption_alignment_classes-2180627-2.patch	5.95 KB	jessebeach
#1	remove_caption_alignment_classes-2180627-1.patch	5.89 KB	wim leers

Comments

Comment #1

wim leers

Ghent 🇧🇪🇪🇺

commented 24 January 2014 at 10:05

Status:

Active

» Needs review

Status	File	Size
new	remove_caption_alignment_classes-2180627-1.patch	5.89 KB

Comment #2

jessebeach commented 27 January 2014 at 19:51

Status	File	Size
new	remove_caption_alignment_classes-2180627-2.patch	5.95 KB
new	interdiff.txt	5.95 KB

I think we can get away with removing this modification:

/**
 * Caption alignment: center alignment needs special care.
 */
.caption.align-center {
  margin-left: auto;
  margin-right: auto;
  clear: both;
}

If we remove the margin: 0 from the .caption class. I read through the referenced article http://stackoverflow.com/a/13363408 and I don't believe the margin: 0 is strictly necessary.