Part of #2006152: [meta] Don't call theme() directly anywhere outside drupal_render().

CommentFileSizeAuthor
#4 interdiff.txt1.01 KBjoelpittet
#4 2177645-theme-d_r-common-4.patch1.03 KBjoelpittet
#2 Screen shot 2014-01-27 at 7.26.13 PM.png67.1 KBekl1773
#1 drupal-core-replace-theme-2177645-1.patch683 bytesinternetdevels

Comments

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-core-replace-theme-2177645-1.patch683 bytes

Here is the patch

ekl1773’s picture

ekl1773
she/her
Primary language English
commented
Status: Needs review » Reviewed & tested by the community
StatusFileSize
new Screen shot 2014-01-27 at 7.26.13 PM.png67.1 KB

I tested this patch by creating a new feed and checking for the presence of the feed icon. It appears to work! There's also a test for this: testFeedIconEscaping() in the drupal_add_feed() tests.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Needs review

Couldn't this go into the existing $build array?

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented
StatusFileSize
new 2177645-theme-d_r-common-4.patch1.03 KB
new interdiff.txt1.01 KB

Can't see why not, saves one more call to that function:)

joelpittet’s picture

joelpittet
he/him
Primary language English
Location Vancouver
commented

Reason I left them separate because I didn't want to array(array(array())) that... FYI

martin107’s picture

martin107 commented
Status: Needs review » Reviewed & tested by the community

Clean implementation, nothing contentious, simple fix.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.