Follow-up from #1889790: [Meta] Allow modules to register links for menus, breadcrumbs and tabs (if not with hook_menu).

The menu system still functions, but much of it still assumes it's also handling routing which is no longer the case. This meta is for tracking the final removal of that assumption and related cleanup.

Add the related steps as child issues of this issue.

Comments

Crell’s picture

Crell commented
Title: [Meta] menu system cleanup » [Meta] Menu system home-stretch
Issue summary: View changes
xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: +Needs issue summary update

The children of this issue that were explicitly tagged as beta blockers have been resolved. What else is outstanding here that would block beta? If nothing else, let's remove the tag from this issue. If there are other major changes to the public menu API, let's discuss them with a core maintainer to see if they should be beta blockers.

Lots of other open issues with the tag:
https://drupal.org/project/issues/search/drupal?status%5B%5D=1&status%5B...

catch’s picture

catch
he/him
Primary language English
commented

There's #2178723: [meta-2] Finalize module-facing API of declaring menu links but that's tagged beta blocker already. I'm not aware of anything else that explicitly blocks beta.

There's a lot of code in menu.inc to move around still but as far as we know that's not massive API changes.

pwolanin’s picture

pwolanin commented

This one might be enough of an API disruption to be done before beta: #2207893: Convert menu tree building to a service.

In addition, the conversion of menu link to entities is not listed here, but feels critical in order to support translated links.

In regard to that - is there an issue to figure out default content translation import? the issue is: #2193777: Menu link translations need to work with content translation, shipped translations need to be compatible

xjm’s picture

xjm
she/her
Primary language English
commented
Issue tags: -beta blocker

Thanks! #1842858: [PP-1] Convert menu links to the new Entity Field API is also tagged as a beta blocker, and is postponed on #2207893: Convert menu tree building to a service., which I previously tagged as a beta target. We can decide what to do with #2207893: Convert menu tree building to a service. on that issue, but I'll untag this one based on #3 and #4.

catch’s picture

catch
he/him
Primary language English
commented

#2193777: Menu link translations need to work with content translation, shipped translations need to be compatible is the translation issue.

catch’s picture

catch
he/him
Primary language English
commented
Status: Active » Closed (duplicate)

I think this is covered by #2178723: [meta-2] Finalize module-facing API of declaring menu links and possibly other criticals.

Marking duplicate. If this needs to be re-opened, it also needs a new issue summary and linked issues.