AliasManager needs AliasWhitelist to do it's job. It currently accepts class as it is. We prefer to use interfaces in such cases, as it allows us to swap/alter selected dependencies.

Let's introduce AliasWhitelistInterface and make AliasManager accept it instead of a class.

Patch follows.

CommentFileSizeAuthor
#1 2176963_1.patch2.57 KBslashrsm

Comments

slashrsm’s picture

slashrsm commented
Status: Active » Needs review
StatusFileSize
new 2176963_1.patch2.57 KB

Patch attached.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
commented
Status: Needs review » Reviewed & tested by the community

I think this is better than changing AliasManager::__construct() to take CacheCollectorInterface explicitly.

catch’s picture

catch
he/him
Primary language English
commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.