Updated: Comment 0

Problem/Motivation

For tests, general reuseabilty etc. we should not mark methods as final.

Proposed resolution

Remaining tasks

User interface changes

API changes

CommentFileSizeAuthor
#6 drupal-final_function-2176397-6.patch663 bytesinternetdevels
#3 core-8.x-2176397-final-functions.patch587 bytescarsato
#2 core-8.x-2176397-final-functions.patch587 bytescarsato

Comments

dawehner’s picture

dawehner
Primary language German
commented
Issue tags: +Novice

.

carsato’s picture

carsato commented
StatusFileSize
new core-8.x-2176397-final-functions.patch587 bytes

Patch rolled.
removed "final" from getContextReference

carsato’s picture

carsato commented
StatusFileSize
new core-8.x-2176397-final-functions.patch587 bytes
carsato’s picture

carsato commented

Sorry. I can't get to remove wrong patches.
The good one is https://drupal.org/files/issues/core-8.x-2176397-final-functions_0.patch , the one visible in #3

star-szr’s picture

star-szr
he/him
Primary language English
commented

Thanks @carsato! While we're changing that line we might as well fix the coding standards violation, the opening curly brace should be on the same line as the function declaration. See https://drupal.org/coding-standards.

To send the patch for review, change the issue status to 'Needs review'.

internetdevels’s picture

internetdevels commented
Status: Active » Needs review
StatusFileSize
new drupal-final_function-2176397-6.patch663 bytes

There are several coding standards issues in this file (mostly related to inline comments). Should we fix them in this issue or open separate one?

star-szr’s picture

star-szr
he/him
Primary language English
commented

Separate issue please and you can add this one as a related issue. Thanks @InternetDevels!

star-szr’s picture

star-szr
he/him
Primary language English
commented
Status: Needs review » Reviewed & tested by the community

And RTBC :)

star-szr’s picture

star-szr
he/him
Primary language English
commented
Issue tags: +Quick fix, +Twig
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
commented
Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.