Updated: Comment 0

Problem/Motivation

For tests, general reuseabilty etc. we should not mark methods as final.

Proposed resolution

Remaining tasks

User interface changes

API changes

Files: 
CommentFileSizeAuthor
#6 drupal-final_function-2176397-6.patch663 bytesInternetDevels
PASSED: [[SimpleTest]]: [MySQL] 59,853 pass(es). View

Comments

dawehner’s picture

Issue tags: +Novice

.

carsato’s picture

Patch rolled.
removed "final" from getContextReference

carsato’s picture

FileSize
587 bytes
carsato’s picture

Sorry. I can't get to remove wrong patches.
The good one is https://drupal.org/files/issues/core-8.x-2176397-final-functions_0.patch , the one visible in #3

Cottser’s picture

Thanks @carsato! While we're changing that line we might as well fix the coding standards violation, the opening curly brace should be on the same line as the function declaration. See https://drupal.org/coding-standards.

To send the patch for review, change the issue status to 'Needs review'.

InternetDevels’s picture

Status: Active » Needs review
FileSize
663 bytes
PASSED: [[SimpleTest]]: [MySQL] 59,853 pass(es). View

There are several coding standards issues in this file (mostly related to inline comments). Should we fix them in this issue or open separate one?

Cottser’s picture

Separate issue please and you can add this one as a related issue. Thanks @InternetDevels!

Cottser’s picture

Status: Needs review » Reviewed & tested by the community

And RTBC :)

Cottser’s picture

Issue tags: +Quick fix, +Twig
webchick’s picture

Status: Reviewed & tested by the community » Fixed

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.