Paypal is case-insensitive regarding emails, that is PayPal@example.com and paypal@example.com are treated as the same email.

Suppose now that a payment method uses email with uppercase letters, When PayPal sends IPN, $_POST['business'] contains email always in lowercase. During access validation module compares emails as they are and finds they are different and return 'Access denied' response. Otherwise we should do case-insensitive comparison.

CommentFileSizeAuthor
#3 paypal_payment-compare_emails-case-insensitive-2176309-3.patch851 bytesalex.bukach
#1 paypal_payment-compare_emails-case-insensitive-2176309-1.patch674 bytesalex.bukach

Comments

alex.bukach’s picture

alex.bukach commented
Status: Active » Needs review
StatusFileSize
new paypal_payment-compare_emails-case-insensitive-2176309-1.patch674 bytes
xano’s picture

xano
he/they
Primary language English
Location Southampton
commented

Man, another edge case? You should do core development ;-) Thanks for reporting this! Can you extend the patch with a code comment explaining why we cast both values to lower case?

alex.bukach’s picture

alex.bukach commented
StatusFileSize
new paypal_payment-compare_emails-case-insensitive-2176309-3.patch851 bytes

Sure.

xano’s picture

xano
he/they
Primary language English
Location Southampton
commented
Status: Needs review » Fixed

Fixed, thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.