Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Comment | File | Size | Author |
---|---|---|---|
#9 | interdiff.txt | 3.15 KB | sun |
#9 | file.htaccess.9.patch | 5.25 KB | sun |
#5 | interdiff.txt | 3.16 KB | sun |
#5 | file.htaccess.5.patch | 7.7 KB | sun |
#2 | drupal8.file-htaccess-return.2.patch | 4.69 KB | sun |
Comments
Comment #1
sunRemoving this change, since unrelated.
Comment #2
sunAttached patch adds unit test coverage.
Note that the test fails on Windows due to #2107287: PHP 5.4 calls a new stream_metadata() method on stream wrappers not implemented by Drupal
Comment #3
chx CreditAttribution: chx commentedLooks good.
Comment #5
sunFixed File API is broken in DUTB tests + stream wrappers of parent site are leaking into all tests.
Comment #6
sunRecalled that I ran into the stream wrapper problem in tests a long time ago already.
Thus, extracted changes, and this is now blocked on #1376122: Stream wrappers of parent site are leaking into all tests
Comment #8
sunTwo years later, #1376122: Stream wrappers of parent site are leaking into all tests is finally done and green now. :)
After that has landed, we can proceed here.
Comment #9
sunThe dependency is finally in... and it makes the new test here finally pass with HEAD as-is. :-)
Polished the new HtaccessUnitTest.
→ RTBC?
Comment #10
tstoecklerLooks good!
Comment #11
alexpottComment #12
alexpottCommitted 747fd61 and pushed to 8.x. Thanks!
Comment #13
sunThanks!
But hm. - A change notice for an added return value?
I'd consider that to be a bit too granular, no?
Comment #14
sunClosing this without a change notice for now, because I still think that an added return value is too minor to justify a change notice.
Please re-open if you disagree.