Add a return value to file_save_htaccess()

+++ b/core/includes/file.inc
@@ -1495,8 +1500,10 @@ function drupal_mkdir($uri, $mode = NULL, $recursive = FALSE, $context = NULL) {
+    // During early update there is no container. When called from
+    // UnitTestBase::setUp(), the container has no config.factory service.
+    $container = \Drupal::getContainer();
+    if (is_object($container) && $container->has('config.factory')) {

Removing this change, since unrelated.

Attached patch adds unit test coverage.

Note that the test fails on Windows due to #2107287: PHP 5.4 calls a new stream_metadata() method on stream wrappers not implemented by Drupal

Fixed File API is broken in DUTB tests + stream wrappers of parent site are leaking into all tests.

Recalled that I ran into the stream wrapper problem in tests a long time ago already.

Thus, extracted changes, and this is now blocked on #1376122: Stream wrappers of parent site are leaking into all tests

Two years later, #1376122: Stream wrappers of parent site are leaking into all tests is finally done and green now. :)

After that has landed, we can proceed here.

The dependency is finally in... and it makes the new test here finally pass with HEAD as-is. :-)

Polished the new HtaccessUnitTest.

→ RTBC?

Looks good!

Committed 747fd61 and pushed to 8.x. Thanks!

Thanks!

But hm. - A change notice for an added return value?

I'd consider that to be a bit too granular, no?

Closing this without a change notice for now, because I still think that an added return value is too minor to justify a change notice.

Please re-open if you disagree.