Problem/Motivation

May plugin types do not have any configuration, but \Drupal\Component\Plugin\Factory\FactoryInterface::createInstance() does require it to be passed on.

Proposed resolution

Fix this by defaulting to an empty array. \Drupal\Component\Plugin\PluginManagerBase::createInstance() already does this, which is the base for most, if not all, plugin managers in core.

Remaining tasks

None.

User interface changes

None.

API changes

No BC breaks.

CommentFileSizeAuthor
#3 drupal_2175569_3.patch5.82 KBXano
#1 drupal_2175569_1.patch2.04 KBXano
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Assigned: Xano » Unassigned
Status: Active » Needs review
FileSize
drupal_2175569_1.patch2.04 KB

Status: Needs review » Needs work

The last submitted patch, 1: drupal_2175569_1.patch, failed testing.

Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented
Status: Needs work » Needs review
FileSize
drupal_2175569_3.patch5.82 KB
Xano’s picture

Xano
he/they
Primary language English
Location Southampton
CreditAttribution: Xano commented

3: drupal_2175569_3.patch queued for re-testing.

ianthomas_uk’s picture

ianthomas_uk
he/him
Primary language English
Location Brighton, UK
CreditAttribution: ianthomas_uk commented
Status: Needs review » Reviewed & tested by the community

Sounds reasonable to me, and you've updated all implementing classes that I could find.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott commented
Status: Reviewed & tested by the community » Fixed

I'd noticed this before. makes sense.

Committed f718eda and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.